Skip to content

Commit 5ef02d9

Browse files
authored
[RISCV] Lower llvm.clear_cache to __riscv_flush_icache for glibc targets (llvm#93481)
This change is a preliminary step to support trampolines on RISC-V. Trampolines are used by flang to implement obtaining the address of an internal program (i.e., a nested function in Fortran parlance). In this change we lower `llvm.clear_cache` intrinsic on glibc targets to `__riscv_flush_icache` which is what GCC is currently doing for Linux targets.
1 parent da2ad44 commit 5ef02d9

File tree

4 files changed

+80
-0
lines changed

4 files changed

+80
-0
lines changed

llvm/include/llvm/IR/RuntimeLibcalls.def

+1
Original file line numberDiff line numberDiff line change
@@ -623,6 +623,7 @@ HANDLE_LIBCALL(RETURN_ADDRESS, nullptr)
623623

624624
// Clear cache
625625
HANDLE_LIBCALL(CLEAR_CACHE, "__clear_cache")
626+
HANDLE_LIBCALL(RISCV_FLUSH_ICACHE, "__riscv_flush_icache")
626627

627628
HANDLE_LIBCALL(UNKNOWN_LIBCALL, nullptr)
628629

llvm/lib/Target/RISCV/RISCVISelLowering.cpp

+25
Original file line numberDiff line numberDiff line change
@@ -662,6 +662,11 @@ RISCVTargetLowering::RISCVTargetLowering(const TargetMachine &TM,
662662

663663
setBooleanContents(ZeroOrOneBooleanContent);
664664

665+
if (getTargetMachine().getTargetTriple().isOSLinux()) {
666+
// Custom lowering of llvm.clear_cache.
667+
setOperationAction(ISD::CLEAR_CACHE, MVT::Other, Custom);
668+
}
669+
665670
if (Subtarget.hasVInstructions()) {
666671
setBooleanVectorContents(ZeroOrOneBooleanContent);
667672

@@ -7142,9 +7147,29 @@ SDValue RISCVTargetLowering::LowerOperation(SDValue Op,
71427147
return lowerVPSpliceExperimental(Op, DAG);
71437148
case ISD::EXPERIMENTAL_VP_REVERSE:
71447149
return lowerVPReverseExperimental(Op, DAG);
7150+
case ISD::CLEAR_CACHE: {
7151+
assert(getTargetMachine().getTargetTriple().isOSLinux() &&
7152+
"llvm.clear_cache only needs custom lower on Linux targets");
7153+
SDLoc DL(Op);
7154+
SDValue Flags = DAG.getConstant(0, DL, Subtarget.getXLenVT());
7155+
return emitFlushICache(DAG, Op.getOperand(0), Op.getOperand(1),
7156+
Op.getOperand(2), Flags, DL);
7157+
}
71457158
}
71467159
}
71477160

7161+
SDValue RISCVTargetLowering::emitFlushICache(SelectionDAG &DAG, SDValue InChain,
7162+
SDValue Start, SDValue End,
7163+
SDValue Flags, SDLoc DL) const {
7164+
MakeLibCallOptions CallOptions;
7165+
std::pair<SDValue, SDValue> CallResult =
7166+
makeLibCall(DAG, RTLIB::RISCV_FLUSH_ICACHE, MVT::isVoid,
7167+
{Start, End, Flags}, CallOptions, DL, InChain);
7168+
7169+
// This function returns void so only the out chain matters.
7170+
return CallResult.second;
7171+
}
7172+
71487173
static SDValue getTargetNode(GlobalAddressSDNode *N, const SDLoc &DL, EVT Ty,
71497174
SelectionDAG &DAG, unsigned Flags) {
71507175
return DAG.getTargetGlobalAddress(N->getGlobal(), DL, Ty, 0, Flags);

llvm/lib/Target/RISCV/RISCVISelLowering.h

+3
Original file line numberDiff line numberDiff line change
@@ -1037,6 +1037,9 @@ class RISCVTargetLowering : public TargetLowering {
10371037
const APInt &AndMask) const override;
10381038

10391039
unsigned getMinimumJumpTableEntries() const override;
1040+
1041+
SDValue emitFlushICache(SelectionDAG &DAG, SDValue InChain, SDValue Start,
1042+
SDValue End, SDValue Flags, SDLoc DL) const;
10401043
};
10411044

10421045
/// As per the spec, the rules for passing vector arguments are as follows:
+51
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5
2+
; RUN: llc -mtriple=riscv32 < %s | FileCheck --check-prefix=RV32 %s
3+
; RUN: llc -mtriple=riscv64 < %s | FileCheck --check-prefix=RV64 %s
4+
; RUN: llc -mtriple=riscv32-unknown-linux-gnu < %s | FileCheck --check-prefix=RV32-LINUX %s
5+
; RUN: llc -mtriple=riscv64-unknown-linux-gnu < %s | FileCheck --check-prefix=RV64-LINUX %s
6+
; RUN: llc -mtriple=riscv32-unknown-linux-musl < %s | FileCheck --check-prefix=RV32-LINUX %s
7+
; RUN: llc -mtriple=riscv64-unknown-linux-musl < %s | FileCheck --check-prefix=RV64-LINUX %s
8+
9+
declare void @llvm.clear_cache(ptr, ptr)
10+
11+
define void @foo(ptr %a, ptr %b) nounwind {
12+
; RV32-LABEL: foo:
13+
; RV32: # %bb.0:
14+
; RV32-NEXT: addi sp, sp, -16
15+
; RV32-NEXT: sw ra, 12(sp) # 4-byte Folded Spill
16+
; RV32-NEXT: call __clear_cache
17+
; RV32-NEXT: lw ra, 12(sp) # 4-byte Folded Reload
18+
; RV32-NEXT: addi sp, sp, 16
19+
; RV32-NEXT: ret
20+
;
21+
; RV64-LABEL: foo:
22+
; RV64: # %bb.0:
23+
; RV64-NEXT: addi sp, sp, -16
24+
; RV64-NEXT: sd ra, 8(sp) # 8-byte Folded Spill
25+
; RV64-NEXT: call __clear_cache
26+
; RV64-NEXT: ld ra, 8(sp) # 8-byte Folded Reload
27+
; RV64-NEXT: addi sp, sp, 16
28+
; RV64-NEXT: ret
29+
;
30+
; RV32-LINUX-LABEL: foo:
31+
; RV32-LINUX: # %bb.0:
32+
; RV32-LINUX-NEXT: addi sp, sp, -16
33+
; RV32-LINUX-NEXT: sw ra, 12(sp) # 4-byte Folded Spill
34+
; RV32-LINUX-NEXT: li a2, 0
35+
; RV32-LINUX-NEXT: call __riscv_flush_icache
36+
; RV32-LINUX-NEXT: lw ra, 12(sp) # 4-byte Folded Reload
37+
; RV32-LINUX-NEXT: addi sp, sp, 16
38+
; RV32-LINUX-NEXT: ret
39+
;
40+
; RV64-LINUX-LABEL: foo:
41+
; RV64-LINUX: # %bb.0:
42+
; RV64-LINUX-NEXT: addi sp, sp, -16
43+
; RV64-LINUX-NEXT: sd ra, 8(sp) # 8-byte Folded Spill
44+
; RV64-LINUX-NEXT: li a2, 0
45+
; RV64-LINUX-NEXT: call __riscv_flush_icache
46+
; RV64-LINUX-NEXT: ld ra, 8(sp) # 8-byte Folded Reload
47+
; RV64-LINUX-NEXT: addi sp, sp, 16
48+
; RV64-LINUX-NEXT: ret
49+
call void @llvm.clear_cache(ptr %a, ptr %b)
50+
ret void
51+
}

0 commit comments

Comments
 (0)