fix(BAlert): remove deprecated property and aria-label for BButton.

Author: phlegx

packages/bootstrap-vue-next/src/components/BAlert/BAlert.vue

@@ -16,7 +16,7 @@
             {{ closeContent }}
           </slot>
         </BButton>
-        <BCloseButton v-else aria-label="closeLabel" v-bind="closeAttrs" @click="hide" />
+        <BCloseButton v-else :aria-label="closeLabel" v-bind="closeAttrs" @click="hide" />
       </template>
     </div>
   </BTransition>
@@ -37,7 +37,6 @@ const props = withDefaults(
     closeVariant?: ButtonVariant | null
     closeClass?: ClassValue
     closeLabel?: string
-    closeWhite?: Booleanish
     closeContent?: string
     noHoverPause?: Booleanish
     dismissible?: Booleanish
@@ -52,7 +51,6 @@ const props = withDefaults(
     closeVariant: 'secondary',
     closeClass: undefined,
     closeLabel: 'Close',
-    closeWhite: false,
     closeContent: undefined,
     noHoverPause: false,
     interval: 1000,
@@ -126,7 +124,6 @@ const isAlertVisible = computed<boolean>(() =>
 
 const closeAttrs = computed(() => ({
   variant: hasCloseSlot.value ? props.closeVariant : undefined,
-  white: !hasCloseSlot.value ? props.closeWhite : undefined,
   class: closeClasses.value,
 }))
 

packages/bootstrap-vue-next/src/components/BAlert/alert.spec.ts

@@ -212,16 +212,6 @@ describe('alert', () => {
     expect($bclosebutton.attributes('aria-label')).toBe('Close')
   })
 
-  it('nested div BButton has aria-label to be Close by default', () => {
-    const wrapper = mount(BAlert, {
-      props: {modelValue: true, dismissible: true},
-      slots: {close: 'foobar'},
-    })
-    const $div = wrapper.get('div')
-    const $bbutton = $div.getComponent(BButton)
-    expect($bbutton.attributes('aria-label')).toBe('Close')
-  })
-
   it('nested div BCloseButton has aria-label to be prop closeLabel', () => {
     const wrapper = mount(BAlert, {
       props: {modelValue: true, dismissible: true, closeLabel: 'foobar'},
@@ -231,16 +221,6 @@ describe('alert', () => {
     expect($bclosebutton.attributes('aria-label')).toBe('foobar')
   })
 
-  it('nested div BButton has aria-label to be prop closeLabel', () => {
-    const wrapper = mount(BAlert, {
-      props: {modelValue: true, dismissible: true, closeLabel: 'foobar'},
-      slots: {close: 'foobar'},
-    })
-    const $div = wrapper.get('div')
-    const $bbutton = $div.getComponent(BButton)
-    expect($bbutton.attributes('aria-label')).toBe('foobar')
-  })
-
   // BCloseButton variant
   it('nested div BCloseButton emits update:modelValue when clicked when modelValue boolean', async () => {
     const wrapper = mount(BAlert, {
@@ -303,15 +283,6 @@ describe('alert', () => {
     expect($bclosebutton.classes()).toContain('foobar')
   })
 
-  it('nested div BCloseButton has class when prop closeWhite', () => {
-    const wrapper = mount(BAlert, {
-      props: {modelValue: true, dismissible: true, closeWhite: true},
-    })
-    const $div = wrapper.get('div')
-    const $bclosebutton = $div.getComponent(BCloseButton)
-    expect($bclosebutton.classes()).toContain('btn-close-white')
-  })
-
   it('nested div BCloseButton has no class when no slot close', () => {
     const wrapper = mount(BAlert, {
       props: {modelValue: true, dismissible: true},
@@ -397,16 +368,6 @@ describe('alert', () => {
     expect($bbutton.classes()).toContain('foobar')
   })
 
-  it('nested div BButton has no class when prop closeWhite', () => {
-    const wrapper = mount(BAlert, {
-      props: {modelValue: true, dismissible: true, closeWhite: true},
-      slots: {close: 'foobar'},
-    })
-    const $div = wrapper.get('div')
-    const $bbutton = $div.getComponent(BButton)
-    expect($bbutton.classes()).not.toContain('btn-close-white')
-  })
-
   it('nested div BButton has class when slot close', () => {
     const wrapper = mount(BAlert, {
       props: {modelValue: true, dismissible: true},