-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Toast animation issue #4498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The sticky transition classes is an issue with the interaction with portal-vue and the transition-group and transition components, which we tried to figure out a workaround, but couldn't |
Crumbs |
We might have to remove the individual transition component from the toasts (when present in a toaster), and just rely on the transition group of the toaster, but then we would loose the ability to rely on the individual toast transition event handlers. Unless we can find an easy way to have the toast subscribe to the enter/leave transition hooks of the parent toaster (and filter based on the toast's root element).. this is assuming the transition-group component works correctly with portalled content. |
The animation issues are caused by bugs in Vue.js Theare open PR's on GitHub which seem to fix the issues: |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution. |
Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you! |
Describe the bug
When there are multiple toasts present, slide animations only work for the first item, and even then there's a hitch in the animation. I made a demo that shows toasts side by side with a vanilla transition-group, with some instructions.
Demo https://codepen.io/cvn/pen/vYEKQdO
A difference with a vanilla transition-group is that when toasts are not animating, they keep a
b-toaster-enter-to
class. And after moving, they also keep ab-toaster-move
class. Like the enter and move animations aren't ever completing.Ref #4473
Expected behavior
Toast move and leave animations should work for all toasts.
Versions
Libraries:
Environment:
The text was updated successfully, but these errors were encountered: