Skip to content

Toast animation issue #4498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cvn opened this issue Dec 13, 2019 · 6 comments
Closed

Toast animation issue #4498

cvn opened this issue Dec 13, 2019 · 6 comments

Comments

@cvn
Copy link
Contributor

cvn commented Dec 13, 2019

Describe the bug

When there are multiple toasts present, slide animations only work for the first item, and even then there's a hitch in the animation. I made a demo that shows toasts side by side with a vanilla transition-group, with some instructions.

Demo https://codepen.io/cvn/pen/vYEKQdO

A difference with a vanilla transition-group is that when toasts are not animating, they keep a b-toaster-enter-to class. And after moving, they also keep a b-toaster-move class. Like the enter and move animations aren't ever completing.

Ref #4473

Expected behavior

Toast move and leave animations should work for all toasts.

Versions

Libraries:

  • BootstrapVue: 2.1.0
  • Bootstrap: 4.4.1
  • Vue: 2.6.10

Environment:

  • OS: macOS Mojave
  • Browser: Chrome 78
@tmorehouse
Copy link
Member

The sticky transition classes is an issue with the interaction with portal-vue and the transition-group and transition components, which we tried to figure out a workaround, but couldn't

@cvn
Copy link
Contributor Author

cvn commented Dec 13, 2019

Crumbs

@tmorehouse
Copy link
Member

tmorehouse commented Dec 13, 2019

We might have to remove the individual transition component from the toasts (when present in a toaster), and just rely on the transition group of the toaster, but then we would loose the ability to rely on the individual toast transition event handlers. Unless we can find an easy way to have the toast subscribe to the enter/leave transition hooks of the parent toaster (and filter based on the toast's root element).. this is assuming the transition-group component works correctly with portalled content.

@jacobmllr95
Copy link
Member

jacobmllr95 commented Sep 4, 2020

The animation issues are caused by bugs in Vue.js transition-group implementation.

Theare open PR's on GitHub which seem to fix the issues:

@stale
Copy link

stale bot commented Dec 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution.

@stale stale bot added the Status: Stale label Dec 5, 2020
@stale
Copy link

stale bot commented Dec 18, 2020

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!

@stale stale bot closed this as completed Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants