Fix annotation handling for AWS

There are scenarios where an annotation may exist and adding a new
annotation will fail if we don't use overwrite.
Additionally delete the annotation on image deletion

Fixes: #KATA-3117

Signed-off-by: Pradipta Banerjee <[email protected]>

Author: bpradipt

Diff for: config/peerpods/podvm/aws-podvm-image-handler.sh

@@ -259,14 +259,35 @@ function add_ami_id_annotation_to_peer_pods_cm() {
         return
     fi
 
-    # Add the image id as annotation to peer-pods-cm configmap
-    kubectl annotate configmap peer-pods-cm -n openshift-sandboxed-containers-operator \
+    # Add the ami id as annotation to peer-pods-cm configmap
+    # Overwrite any existing values
+    kubectl annotate --overwrite configmap peer-pods-cm -n openshift-sandboxed-containers-operator \
         "LATEST_AMI_ID=${AMI_ID}" ||
         error_exit "Failed to add the ami id as annotation to peer-pods-cm configmap"
 
     echo "AMI id added as annotation to peer-pods-cm configmap successfully"
 }
 
+# Function to delete the LATEST_AMI_ID annotation from the peer-pods-cm configmap
+
+function delete_ami_id_annotation_from_peer_pods_cm() {
+    echo "Deleting ami id annotation from peer-pods-cm configmap"
+
+    # Check if the peer-pods-cm configmap exists
+    if ! kubectl get configmap peer-pods-cm -n openshift-sandboxed-containers-operator >/dev/null 2>&1; then
+        echo "peer-pods-cm configmap does not exist. Skipping deleting the ami id"
+        return
+    fi
+
+    # Delete the ami id annotation from peer-pods-cm configmap
+    kubectl annotate configmap peer-pods-cm -n openshift-sandboxed-containers-operator \
+        "LATEST_AMI_ID-" ||
+        error_exit "Failed to delete the ami id annotation from peer-pods-cm configmap"
+
+    echo "Ami id annotation deleted from peer-pods-cm configmap successfully"
+}
+
+
 # Function to create the ami in AWS
 
 function create_ami() {
@@ -324,6 +345,9 @@ function delete_ami_using_id() {
     aws ec2 deregister-image --region "${AWS_REGION}" --image-id "${AMI_ID}" ||
         error_exit "Failed to delete the ami"
 
+    # Remove the ami id annotation from peer-pods-cm configmap
+    delete_ami_id_annotation_from_peer_pods_cm
+
 }
 
 # display help message