Skip to content

Commit 97d6ef7

Browse files
authored
Fixing GRPC API as per discussion in today's meeting (kubernetes#22)
1 parent f5f3de1 commit 97d6ef7

File tree

1 file changed

+6
-18
lines changed

1 file changed

+6
-18
lines changed

keps/sig-storage/20191125-bucket-provisioning.md

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -566,12 +566,9 @@ This call is made to create the bucket in the backend. If the bucket already exi
566566
567567
```
568568
message ProvisionerCreateBucketRequest {
569+
// This field is REQUIRED
569570
string bucket_name = 1;
570571

571-
string region = 2;
572-
573-
string zone = 3;
574-
575572
map<string,string> bucket_context = 4;
576573

577574
enum AnonymousBucketAccessMode {
@@ -582,8 +579,6 @@ message ProvisionerCreateBucketRequest {
582579
}
583580

584581
AnonymousBucketAccessMode anonymous_bucket_access_mode = 5;
585-
586-
map<string,string> secrets = 6;
587582
}
588583

589584
message ProvisionerCreateBucketResponse {
@@ -597,12 +592,9 @@ This call is made to delete the bucket in the backend. If the bucket has already
597592
598593
```
599594
message ProvisionerDeleteBucketRequest {
595+
// This field is REQUIRED
600596
string bucket_name = 1;
601597

602-
string region = 2;
603-
604-
string zone = 3;
605-
606598
map<string,string> bucket_context = 4;
607599
}
608600

@@ -621,16 +613,14 @@ If the `principal` is empty, then a new service account should be created in the
621613
622614
```
623615
message ProvisionerGrantBucketAccessRequest {
616+
// This field is REQUIRED
624617
string bucket_name = 1;
625618

626-
string region = 2;
627-
628-
string zone = 3;
629-
630619
map<string,string> bucket_context = 4;
631620

632621
string principal = 5;
633622

623+
// This field is REQUIRED
634624
string access_policy = 6;
635625
}
636626

@@ -651,14 +641,12 @@ This call revokes all access to a particular bucket from a principal.
651641
652642
```
653643
message ProvisionerRevokeBucketAccessRequest {
644+
// This field is REQUIRED
654645
string bucket_name = 1;
655646

656-
string region = 2;
657-
658-
string zone = 3;
659-
660647
map<string,string> bucket_context = 4;
661648

649+
// This field is REQUIRED
662650
string principal = 5;
663651
}
664652

0 commit comments

Comments
 (0)