Skip to content

Commit 02b07ad

Browse files
author
Ryan Stone
committed
Use a semicolon to separate frames
Use a semicolon instead of a comma to separate frames in the flamegraph input. Commas can appear in demangled C++ function names (e.g. foo(int, int) ) so using commas to separate frames can confuse the parser.
1 parent 2672d89 commit 02b07ad

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

flamegraph.pl

+2-2
Original file line numberDiff line numberDiff line change
@@ -135,8 +135,8 @@ sub color {
135135

136136
sub flow {
137137
my ($a, $b, $v) = @_;
138-
my @A = split ",", $a;
139-
my @B = split ",", $b;
138+
my @A = split ";", $a;
139+
my @B = split ";", $b;
140140

141141
my $len_a = $#A;
142142
my $len_b = $#B;

stackcollapse-perf.pl

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ sub remember_stack {
6868
chomp;
6969

7070
if (m/^$/) {
71-
remember_stack(join(",", @stack), 1) if @stack;
71+
remember_stack(join(";", @stack), 1) if @stack;
7272
undef @stack;
7373
next;
7474
}

stackcollapse-stap.pl

+1-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ sub remember_stack {
6464
chomp;
6565

6666
if (m/^\s*(\d+)+$/) {
67-
remember_stack(join(",", @stack), $1);
67+
remember_stack(join(";", @stack), $1);
6868
@stack = ();
6969
next;
7070
}

stackcollapse.pl

+1-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ sub remember_stack {
6666
chomp;
6767

6868
if (m/^\s*(\d+)+$/) {
69-
remember_stack(join(",", @stack), $1);
69+
remember_stack(join(";", @stack), $1);
7070
@stack = ();
7171
next;
7272
}

0 commit comments

Comments
 (0)