Skip to content

Commit 47156c2

Browse files
committed
Remove windows and macos from CI workflow as they are actually running linux
Removes the windows and macos matrix from the CI workflow as they were never actually setting the OS. Both were running against the "ubuntu-latest" OS. Trying to actually use them would not work either as neither windows or macos is supported for service containers. A different means will be needed to test on those platforms. Until that's done, this removes those from the matrix as we were simply running the same thing 3x for the same node versions.
1 parent 973a593 commit 47156c2

File tree

1 file changed

+13
-3
lines changed

1 file changed

+13
-3
lines changed

Diff for: .github/workflows/ci.yml

+13-3
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ jobs:
2121
- run: yarn lint
2222
build:
2323
needs: lint
24-
runs-on: ubuntu-latest
2524
services:
2625
postgres:
2726
image: postgres:11
@@ -35,9 +34,17 @@ jobs:
3534
options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5
3635
strategy:
3736
matrix:
38-
node: ['10', '12', '14', '16', '18']
39-
os: [ubuntu-latest, windows-latest, macos-latest]
37+
node:
38+
- '10'
39+
- '12'
40+
- '14'
41+
- '16'
42+
- '18'
43+
- '20'
44+
os:
45+
- ubuntu-latest
4046
name: Node.js ${{ matrix.node }} (${{ matrix.os }})
47+
runs-on: ${{ matrix.os }}
4148
env:
4249
PGUSER: postgres
4350
PGHOST: localhost
@@ -47,6 +54,9 @@ jobs:
4754
SCRAM_TEST_PGUSER: scram_test
4855
SCRAM_TEST_PGPASSWORD: test4scram
4956
steps:
57+
- name: Show OS
58+
run: |
59+
uname -a
5060
- run: |
5161
psql \
5262
-c "SET password_encryption = 'scram-sha-256'" \

0 commit comments

Comments
 (0)