Skip to content

Commit 5341a2a

Browse files
authored
Revert "Revert "Support additional tls.connect() options (#1996)" (#2010)" (#2113)
This reverts commit 510a273.
1 parent 1d48051 commit 5341a2a

File tree

2 files changed

+6
-34
lines changed

2 files changed

+6
-34
lines changed

packages/pg/lib/connection-fast.js

+3-17
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ var Writer = require('buffer-writer')
1515
// eslint-disable-next-line
1616
var PacketStream = require('pg-packet-stream')
1717

18-
var warnDeprecation = require('./compat/warn-deprecation')
19-
2018
var TEXT_MODE = 0
2119

2220
// TODO(bmc) support binary mode here
@@ -95,21 +93,9 @@ Connection.prototype.connect = function (port, host) {
9593
return self.emit('error', new Error('There was an error establishing an SSL connection'))
9694
}
9795
var tls = require('tls')
98-
const options = {
99-
socket: self.stream,
100-
checkServerIdentity: self.ssl.checkServerIdentity || tls.checkServerIdentity,
101-
rejectUnauthorized: self.ssl.rejectUnauthorized,
102-
ca: self.ssl.ca,
103-
pfx: self.ssl.pfx,
104-
key: self.ssl.key,
105-
passphrase: self.ssl.passphrase,
106-
cert: self.ssl.cert,
107-
secureOptions: self.ssl.secureOptions,
108-
NPNProtocols: self.ssl.NPNProtocols
109-
}
110-
if (typeof self.ssl.rejectUnauthorized !== 'boolean') {
111-
warnDeprecation('Implicit disabling of certificate verification is deprecated and will be removed in pg 8. Specify `rejectUnauthorized: true` to require a valid CA or `rejectUnauthorized: false` to explicitly opt out of MITM protection.', 'PG-SSL-VERIFY')
112-
}
96+
const options = Object.assign({
97+
socket: self.stream
98+
}, self.ssl)
11399
if (net.isIP(host) === 0) {
114100
options.servername = host
115101
}

packages/pg/lib/connection.js

+3-17
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ var util = require('util')
1414
var Writer = require('buffer-writer')
1515
var Reader = require('packet-reader')
1616

17-
var warnDeprecation = require('./compat/warn-deprecation')
18-
1917
var TEXT_MODE = 0
2018
var BINARY_MODE = 1
2119
var Connection = function (config) {
@@ -93,21 +91,9 @@ Connection.prototype.connect = function (port, host) {
9391
return self.emit('error', new Error('There was an error establishing an SSL connection'))
9492
}
9593
var tls = require('tls')
96-
const options = {
97-
socket: self.stream,
98-
checkServerIdentity: self.ssl.checkServerIdentity || tls.checkServerIdentity,
99-
rejectUnauthorized: self.ssl.rejectUnauthorized,
100-
ca: self.ssl.ca,
101-
pfx: self.ssl.pfx,
102-
key: self.ssl.key,
103-
passphrase: self.ssl.passphrase,
104-
cert: self.ssl.cert,
105-
secureOptions: self.ssl.secureOptions,
106-
NPNProtocols: self.ssl.NPNProtocols
107-
}
108-
if (typeof self.ssl.rejectUnauthorized !== 'boolean') {
109-
warnDeprecation('Implicit disabling of certificate verification is deprecated and will be removed in pg 8. Specify `rejectUnauthorized: true` to require a valid CA or `rejectUnauthorized: false` to explicitly opt out of MITM protection.', 'PG-SSL-VERIFY')
110-
}
94+
const options = Object.assign({
95+
socket: self.stream
96+
}, self.ssl)
11197
if (net.isIP(host) === 0) {
11298
options.servername = host
11399
}

0 commit comments

Comments
 (0)