Skip to content

Commit 8271d21

Browse files
committed
chore(): remove emitClose and added compilation for async iterators
1 parent b5bcda6 commit 8271d21

File tree

4 files changed

+10
-7
lines changed

4 files changed

+10
-7
lines changed

Diff for: packages/pg-protocol/package.json

+5-1
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,9 @@
2121
"build:watch": "tsc --watch",
2222
"prepublish": "yarn build",
2323
"pretest": "yarn build"
24-
}
24+
},
25+
"files": [
26+
"/dist/*{js,ts,map}",
27+
"/src"
28+
]
2529
}

Diff for: packages/pg-query-stream/src/index.ts

+3-5
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Readable } from 'stream'
2-
import { Submittable, Connection, types } from 'pg'
2+
import { Submittable, Connection } from 'pg'
33
import Cursor from 'pg-cursor'
44

55
interface PgQueryStreamConfig {
@@ -23,9 +23,8 @@ class PgQueryStream extends Readable implements Submittable {
2323

2424
constructor(text: string, values?: any[], config: PgQueryStreamConfig = {}) {
2525
const { batchSize, highWaterMark = 100 } = config
26-
// https://nodejs.org/api/stream.html#stream_new_stream_readable_options
27-
//@ts-expect-error
28-
super({ objectMode: true, emitClose: true, autoDestroy: true, highWaterMark: batchSize || highWaterMark })
26+
27+
super({ objectMode: true, autoDestroy: true, highWaterMark: batchSize || highWaterMark })
2928
this.cursor = new Cursor(text, values, config)
3029

3130
// delegate Submittable callbacks to cursor
@@ -55,7 +54,6 @@ class PgQueryStream extends Readable implements Submittable {
5554
_read(size: number) {
5655
this.cursor.read(size, (err: Error, rows: any[], result: any) => {
5756
if (err) {
58-
// https://nodejs.org/api/stream.html#stream_errors_while_reading
5957
this.destroy(err)
6058
} else {
6159
for (const row of rows) this.push(row)

Diff for: packages/pg-query-stream/test/async-iterator.es6.ts renamed to packages/pg-query-stream/test/async-iterator.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import QueryStream from '../'
1+
import QueryStream from '../dist'
22
import pg from 'pg'
33
import assert from 'assert'
44

Diff for: packages/pg-query-stream/tsconfig.json

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
"pretty": true,
1212
"outDir": "dist",
1313
"incremental": true,
14+
"downlevelIteration": true,
1415
"baseUrl": ".",
1516
"declaration": true,
1617
"types": [

0 commit comments

Comments
 (0)