Only release client once on an error. (#3)

Prevent `generic-pool` error when releasing a client with an error.

Fixes #2

Author: Lee Symes

Diff for: index.js

@@ -60,13 +60,14 @@ Pool.prototype.connect = function (cb) {
       this.log('acquire client')
 
       client.release = function (err) {
+        delete client.release
         if (err) {
-          this.log('release client. error:', err)
+          this.log('destroy client. error:', err)
           this.pool.destroy(client)
+        } else {
+          this.log('release client')
+          this.pool.release(client)
         }
-        this.log('release client')
-        delete client.release
-        this.pool.release(client)
       }.bind(this)
 
       if (cb) {

Diff for: test/index.js

@@ -89,7 +89,18 @@ describe('pool', function () {
     }))
 
     it('recovers from all errors', co.wrap(function * () {
-      var pool = new Pool({ poolSize: 9 })
+      var pool = new Pool({
+        poolSize: 9,
+        log: function (str, level) {
+          // Custom logging function to ensure we are not causing errors or warnings
+          // inside the `generic-pool` library.
+          if (level === 'error' || level === 'warn') {
+            expect().fail('An error or warning was logged from the generic pool library.\n' +
+                          'Level: ' + level + '\n' +
+                          'Message: ' + str + '\n')
+          }
+        }
+      })
       var count = 0
 
       while (count++ < 30) {