Skip to content

Commit edfe1aa

Browse files
committed
Merge pull request #16 from brianc/conform-to-readable-stream-spec
Conform to readable stream spec
2 parents e9d1872 + 27bba8d commit edfe1aa

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

Diff for: package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,6 @@
3232
},
3333
"dependencies": {
3434
"pg-cursor": "1.0.0",
35-
"readable-stream": "^1.0.27-1"
35+
"readable-stream": "^2.0.4"
3636
}
3737
}

Diff for: test/fast-reader.js

+7-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,13 @@ helper('fast reader', function(client) {
1010
var count = 0
1111
stream.on('readable', function() {
1212
var res = stream.read()
13-
assert(res, 'should not return null on evented reader')
13+
if (result.length !== 201) {
14+
assert(res, 'should not return null on evented reader')
15+
} else {
16+
//a readable stream will emit a null datum when it finishes being readable
17+
//https://nodejs.org/api/stream.html#stream_event_readable
18+
assert.equal(res, null)
19+
}
1420
if(res) {
1521
result.push(res.num)
1622
}

0 commit comments

Comments
 (0)