Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes 8.13.0 #3315

Closed
kirrg001 opened this issue Sep 19, 2024 · 15 comments
Closed

Release notes 8.13.0 #3315

kirrg001 opened this issue Sep 19, 2024 · 15 comments

Comments

@kirrg001
Copy link

Hi there!

Could you please publish release notes for 8.13.0?

The diff looks pretty big:
[email protected]@8.13.0

Thanks a lot

@markedwards
Copy link

Can we please have release notes? We can't upgrade without knowing what's changed.

@Yareaj
Copy link

Yareaj commented Oct 21, 2024

Bump on this!

@DavideViolante
Copy link
Contributor

@brianc

@brianc
Copy link
Owner

brianc commented Oct 31, 2024

https://github.com/brianc/node-postgres/blob/master/CHANGELOG.md#pg8130

@brianc brianc closed this as completed Oct 31, 2024
@DavideViolante
Copy link
Contributor

Sorry but the PR linked in the changelog changes just 2 lines of code and add 1 test, while the comparison between v8.12 and v8.13 are 807 additions and 1,558 deletions.
A better detail on the changelog would be appreciated.
Also v8.13.1 is missing.

@DavideViolante
Copy link
Contributor

I recommend you to use semantic-release or similar in the future so you can automate and improve the process of the releases and changelog.
There are at least 4 different (but closed) issues about changelog, so it's a problem that developers are now feeling.
Since pg is a core library in any project, we can't upgrade without knowing the changes and the reason of the changes, as @markedwards said.

@kirrg001
Copy link
Author

kirrg001 commented Dec 9, 2024

cc @MyNameIsNeXTSTEP Could you please help?

@MyNameIsNeXTSTEP
Copy link
Contributor

@kirrg001 I'd like to
Give me a little guiadence what to do exactly please

@kirrg001
Copy link
Author

kirrg001 commented Dec 9, 2024

The git diff https://github.com/brianc/node-postgres/compare/[email protected]@8.13.0 looks very big. It contains 28 commits, 807 additions and 1,558 deletions.

The community was wondering why the public changelog only contains one change:

Add ability to specify query timeout on #3074.

Could you please double check and confirm that this is the only customer facing change?

Thanks a lot!

@MyNameIsNeXTSTEP
Copy link
Contributor

MyNameIsNeXTSTEP commented Dec 9, 2024

@kirrg001
If i understood you correctly, here what i've done so far.

As I explored the comparing changes I have found these customer facing changes (which customers may face using the lib) not inluded in the current changelog description for v8.13.0:

  • PR 3114
    • Docs example of pg-cloudflare usage in a non-nodejs environment
  • PR 3170
    • Check Cloudflare API environment first, fallback to NodeJS in case of failure
  • PR 3251 (maybe for contributiors)
    • Devcontainer now uses postgres:14-alpine

@kirrg001
Copy link
Author

Could you please update your CHANGELOG?

Furthermore, it would be really helpful for the community if you could start using GH releases as well.

Thank you!

@MyNameIsNeXTSTEP
Copy link
Contributor

@brianc FYI

@wulfsolter
Copy link

Fwiw, I am happy with current release practices and grateful for all the hard work and contributions over the years. Thank you!

Straight forward enough to use git to see what files changed between releases.

@kirrg001
Copy link
Author

I am also confused why there is no changelog entry for 8.13.1.

@DavideViolante
Copy link
Contributor

DavideViolante commented Dec 11, 2024

Just use the github releases please @brianc , it's extremely simple:

  • people make changes, merge some PRs
  • go to releases, click New release, click "Generate release notes"
  • click publish and all the changes will be very clear for everyone

In this way you save time on creating tags, updating changelog, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants