End event doesn't fire on error

[patriksimek]

node 0.11.12, node-postgres 3.0.1

pg.connect("postgres://...", function(err, client, done) {
    console.log('query');
    var q = client.query("select * from notexistingtable", []);
    q.on('error', function(err) {
        console.log('error');
    });
    q.on('end', function() {
        console.log('done');
    });
});

result in:

query
error

But there is no done reported in console.

Documentation says about End event: "Emitted by the query when all rows have been returned or when an error has been encountered. In either circumstance, the query's execution is finished and it is no longer interacting with the connection."

Work fine in node-postgres 2.8.5.

[brianc]

Yeah this was a breaking change in version 3.0 of node-postgres

https://github.com/brianc/node-postgres/blob/master/NEWS.md#v300

Thanks for pointing out that bit in the documentation - will update it.

[patriksimek]

Thanks, I missed that document.