From 33e8249e355e2e72eb98a3966676fe60d6ed4a75 Mon Sep 17 00:00:00 2001 From: Andy Young Date: Mon, 10 Feb 2025 12:53:15 +0000 Subject: [PATCH 1/2] fix(pg-pool): preserve original error on connection timeout, don't throw on readonly .message e.g. ErrorEvent Fixes https://github.com/brianc/node-postgres/issues/3373 --- packages/pg-pool/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/pg-pool/index.js b/packages/pg-pool/index.js index 94004e031..43a37f67e 100644 --- a/packages/pg-pool/index.js +++ b/packages/pg-pool/index.js @@ -244,7 +244,7 @@ class Pool extends EventEmitter { // remove the dead client from our list of clients this._clients = this._clients.filter((c) => c !== client) if (timeoutHit) { - err.message = 'Connection terminated due to connection timeout' + err = new Error('Connection terminated due to connection timeout', { cause: err } ) } // this client won’t be released, so move on immediately From b6e85262b254375495c7fd553b41e1ba3d61a675 Mon Sep 17 00:00:00 2001 From: Andy Young Date: Mon, 10 Feb 2025 12:59:55 +0000 Subject: [PATCH 2/2] Fix lint --- packages/pg-pool/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/pg-pool/index.js b/packages/pg-pool/index.js index 43a37f67e..e7d2d8833 100644 --- a/packages/pg-pool/index.js +++ b/packages/pg-pool/index.js @@ -244,7 +244,7 @@ class Pool extends EventEmitter { // remove the dead client from our list of clients this._clients = this._clients.filter((c) => c !== client) if (timeoutHit) { - err = new Error('Connection terminated due to connection timeout', { cause: err } ) + err = new Error('Connection terminated due to connection timeout', { cause: err }) } // this client won’t be released, so move on immediately