Skip to content

Commit 04a3a16

Browse files
author
Chris Brody
authored
move constants in generated android/build.gradle (#140)
(using single quotes in definition of `DEFAULT_BUILD_TOOLS_VERSION`) and remove some comments that are not needed
1 parent cc22885 commit 04a3a16

File tree

24 files changed

+120
-192
lines changed

24 files changed

+120
-192
lines changed

‎templates/android.js

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@ module.exports = platform => [{
22
name: () => `${platform}/build.gradle`,
33
content: ({ packageIdentifier }) => `// ${platform}/build.gradle
44
5+
def DEFAULT_COMPILE_SDK_VERSION = 28
6+
def DEFAULT_BUILD_TOOLS_VERSION = '28.0.3'
7+
def DEFAULT_MIN_SDK_VERSION = 16
8+
def DEFAULT_TARGET_SDK_VERSION = 28
9+
510
def safeExtGet(prop, fallback) {
611
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
712
}
@@ -24,14 +29,6 @@ buildscript {
2429
apply plugin: 'com.android.library'
2530
apply plugin: 'maven'
2631
27-
// Matches values in recent template from React Native 0.59 / 0.60
28-
// https://github.com/facebook/react-native/blob/0.59-stable/template/android/build.gradle#L5-L9
29-
// https://github.com/facebook/react-native/blob/0.60-stable/template/android/build.gradle#L5-L9
30-
def DEFAULT_COMPILE_SDK_VERSION = 28
31-
def DEFAULT_BUILD_TOOLS_VERSION = "28.0.3"
32-
def DEFAULT_MIN_SDK_VERSION = 16
33-
def DEFAULT_TARGET_SDK_VERSION = 28
34-
3532
android {
3633
compileSdkVersion safeExtGet('compileSdkVersion', DEFAULT_COMPILE_SDK_VERSION)
3734
buildToolsVersion safeExtGet('buildToolsVersion', DEFAULT_BUILD_TOOLS_VERSION)

‎tests/integration/cli/create/view/__snapshots__/cli-create-with-view.test.js.snap

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,11 @@ sdk.dir=/Users/{username}/Library/Android/sdk
100100
"name": "react-native-integration-view-test-package/android/build.gradle",
101101
"theContent": "// android/build.gradle
102102
103+
def DEFAULT_COMPILE_SDK_VERSION = 28
104+
def DEFAULT_BUILD_TOOLS_VERSION = '28.0.3'
105+
def DEFAULT_MIN_SDK_VERSION = 16
106+
def DEFAULT_TARGET_SDK_VERSION = 28
107+
103108
def safeExtGet(prop, fallback) {
104109
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
105110
}
@@ -122,14 +127,6 @@ buildscript {
122127
apply plugin: 'com.android.library'
123128
apply plugin: 'maven'
124129
125-
// Matches values in recent template from React Native 0.59 / 0.60
126-
// https://github.com/facebook/react-native/blob/0.59-stable/template/android/build.gradle#L5-L9
127-
// https://github.com/facebook/react-native/blob/0.60-stable/template/android/build.gradle#L5-L9
128-
def DEFAULT_COMPILE_SDK_VERSION = 28
129-
def DEFAULT_BUILD_TOOLS_VERSION = \\"28.0.3\\"
130-
def DEFAULT_MIN_SDK_VERSION = 16
131-
def DEFAULT_TARGET_SDK_VERSION = 28
132-
133130
android {
134131
compileSdkVersion safeExtGet('compileSdkVersion', DEFAULT_COMPILE_SDK_VERSION)
135132
buildToolsVersion safeExtGet('buildToolsVersion', DEFAULT_BUILD_TOOLS_VERSION)

‎tests/integration/cli/create/with-defaults/__snapshots__/cli-create-with-defaults.test.js.snap

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,11 @@ sdk.dir=/Users/{username}/Library/Android/sdk
100100
"name": "react-native-integration-test-package/android/build.gradle",
101101
"theContent": "// android/build.gradle
102102
103+
def DEFAULT_COMPILE_SDK_VERSION = 28
104+
def DEFAULT_BUILD_TOOLS_VERSION = '28.0.3'
105+
def DEFAULT_MIN_SDK_VERSION = 16
106+
def DEFAULT_TARGET_SDK_VERSION = 28
107+
103108
def safeExtGet(prop, fallback) {
104109
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
105110
}
@@ -122,14 +127,6 @@ buildscript {
122127
apply plugin: 'com.android.library'
123128
apply plugin: 'maven'
124129
125-
// Matches values in recent template from React Native 0.59 / 0.60
126-
// https://github.com/facebook/react-native/blob/0.59-stable/template/android/build.gradle#L5-L9
127-
// https://github.com/facebook/react-native/blob/0.60-stable/template/android/build.gradle#L5-L9
128-
def DEFAULT_COMPILE_SDK_VERSION = 28
129-
def DEFAULT_BUILD_TOOLS_VERSION = \\"28.0.3\\"
130-
def DEFAULT_MIN_SDK_VERSION = 16
131-
def DEFAULT_TARGET_SDK_VERSION = 28
132-
133130
android {
134131
compileSdkVersion safeExtGet('compileSdkVersion', DEFAULT_COMPILE_SDK_VERSION)
135132
buildToolsVersion safeExtGet('buildToolsVersion', DEFAULT_BUILD_TOOLS_VERSION)

‎tests/with-injection/create/view/with-defaults/__snapshots__/create-view-with-defaults.test.js.snap

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,11 @@ content:
175175
--------
176176
// android/build.gradle
177177
178+
def DEFAULT_COMPILE_SDK_VERSION = 28
179+
def DEFAULT_BUILD_TOOLS_VERSION = '28.0.3'
180+
def DEFAULT_MIN_SDK_VERSION = 16
181+
def DEFAULT_TARGET_SDK_VERSION = 28
182+
178183
def safeExtGet(prop, fallback) {
179184
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
180185
}
@@ -197,14 +202,6 @@ buildscript {
197202
apply plugin: 'com.android.library'
198203
apply plugin: 'maven'
199204
200-
// Matches values in recent template from React Native 0.59 / 0.60
201-
// https://github.com/facebook/react-native/blob/0.59-stable/template/android/build.gradle#L5-L9
202-
// https://github.com/facebook/react-native/blob/0.60-stable/template/android/build.gradle#L5-L9
203-
def DEFAULT_COMPILE_SDK_VERSION = 28
204-
def DEFAULT_BUILD_TOOLS_VERSION = \\"28.0.3\\"
205-
def DEFAULT_MIN_SDK_VERSION = 16
206-
def DEFAULT_TARGET_SDK_VERSION = 28
207-
208205
android {
209206
compileSdkVersion safeExtGet('compileSdkVersion', DEFAULT_COMPILE_SDK_VERSION)
210207
buildToolsVersion safeExtGet('buildToolsVersion', DEFAULT_BUILD_TOOLS_VERSION)

‎tests/with-injection/create/view/with-example/with-defaults/__snapshots__/create-view-with-example-with-defaults.test.js.snap

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,11 @@ content:
180180
--------
181181
// android/build.gradle
182182
183+
def DEFAULT_COMPILE_SDK_VERSION = 28
184+
def DEFAULT_BUILD_TOOLS_VERSION = '28.0.3'
185+
def DEFAULT_MIN_SDK_VERSION = 16
186+
def DEFAULT_TARGET_SDK_VERSION = 28
187+
183188
def safeExtGet(prop, fallback) {
184189
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
185190
}
@@ -202,14 +207,6 @@ buildscript {
202207
apply plugin: 'com.android.library'
203208
apply plugin: 'maven'
204209
205-
// Matches values in recent template from React Native 0.59 / 0.60
206-
// https://github.com/facebook/react-native/blob/0.59-stable/template/android/build.gradle#L5-L9
207-
// https://github.com/facebook/react-native/blob/0.60-stable/template/android/build.gradle#L5-L9
208-
def DEFAULT_COMPILE_SDK_VERSION = 28
209-
def DEFAULT_BUILD_TOOLS_VERSION = \\"28.0.3\\"
210-
def DEFAULT_MIN_SDK_VERSION = 16
211-
def DEFAULT_TARGET_SDK_VERSION = 28
212-
213210
android {
214211
compileSdkVersion safeExtGet('compileSdkVersion', DEFAULT_COMPILE_SDK_VERSION)
215212
buildToolsVersion safeExtGet('buildToolsVersion', DEFAULT_BUILD_TOOLS_VERSION)

‎tests/with-injection/create/view/with-example/with-options/__snapshots__/create-view-with-example-with-options.test.js.snap

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,11 @@ content:
180180
--------
181181
// android/build.gradle
182182
183+
def DEFAULT_COMPILE_SDK_VERSION = 28
184+
def DEFAULT_BUILD_TOOLS_VERSION = '28.0.3'
185+
def DEFAULT_MIN_SDK_VERSION = 16
186+
def DEFAULT_TARGET_SDK_VERSION = 28
187+
183188
def safeExtGet(prop, fallback) {
184189
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
185190
}
@@ -202,14 +207,6 @@ buildscript {
202207
apply plugin: 'com.android.library'
203208
apply plugin: 'maven'
204209
205-
// Matches values in recent template from React Native 0.59 / 0.60
206-
// https://github.com/facebook/react-native/blob/0.59-stable/template/android/build.gradle#L5-L9
207-
// https://github.com/facebook/react-native/blob/0.60-stable/template/android/build.gradle#L5-L9
208-
def DEFAULT_COMPILE_SDK_VERSION = 28
209-
def DEFAULT_BUILD_TOOLS_VERSION = \\"28.0.3\\"
210-
def DEFAULT_MIN_SDK_VERSION = 16
211-
def DEFAULT_TARGET_SDK_VERSION = 28
212-
213210
android {
214211
compileSdkVersion safeExtGet('compileSdkVersion', DEFAULT_COMPILE_SDK_VERSION)
215212
buildToolsVersion safeExtGet('buildToolsVersion', DEFAULT_BUILD_TOOLS_VERSION)

‎tests/with-injection/create/view/with-options/for-android/__snapshots__/lib-view-android-config-options.test.js.snap

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,11 @@ content:
144144
--------
145145
// android/build.gradle
146146
147+
def DEFAULT_COMPILE_SDK_VERSION = 28
148+
def DEFAULT_BUILD_TOOLS_VERSION = '28.0.3'
149+
def DEFAULT_MIN_SDK_VERSION = 16
150+
def DEFAULT_TARGET_SDK_VERSION = 28
151+
147152
def safeExtGet(prop, fallback) {
148153
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
149154
}
@@ -166,14 +171,6 @@ buildscript {
166171
apply plugin: 'com.android.library'
167172
apply plugin: 'maven'
168173
169-
// Matches values in recent template from React Native 0.59 / 0.60
170-
// https://github.com/facebook/react-native/blob/0.59-stable/template/android/build.gradle#L5-L9
171-
// https://github.com/facebook/react-native/blob/0.60-stable/template/android/build.gradle#L5-L9
172-
def DEFAULT_COMPILE_SDK_VERSION = 28
173-
def DEFAULT_BUILD_TOOLS_VERSION = \\"28.0.3\\"
174-
def DEFAULT_MIN_SDK_VERSION = 16
175-
def DEFAULT_TARGET_SDK_VERSION = 28
176-
177174
android {
178175
compileSdkVersion safeExtGet('compileSdkVersion', DEFAULT_COMPILE_SDK_VERSION)
179176
buildToolsVersion safeExtGet('buildToolsVersion', DEFAULT_BUILD_TOOLS_VERSION)

‎tests/with-injection/create/with-defaults/__snapshots__/create-with-defaults.test.js.snap

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,11 @@ content:
175175
--------
176176
// android/build.gradle
177177
178+
def DEFAULT_COMPILE_SDK_VERSION = 28
179+
def DEFAULT_BUILD_TOOLS_VERSION = '28.0.3'
180+
def DEFAULT_MIN_SDK_VERSION = 16
181+
def DEFAULT_TARGET_SDK_VERSION = 28
182+
178183
def safeExtGet(prop, fallback) {
179184
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
180185
}
@@ -197,14 +202,6 @@ buildscript {
197202
apply plugin: 'com.android.library'
198203
apply plugin: 'maven'
199204
200-
// Matches values in recent template from React Native 0.59 / 0.60
201-
// https://github.com/facebook/react-native/blob/0.59-stable/template/android/build.gradle#L5-L9
202-
// https://github.com/facebook/react-native/blob/0.60-stable/template/android/build.gradle#L5-L9
203-
def DEFAULT_COMPILE_SDK_VERSION = 28
204-
def DEFAULT_BUILD_TOOLS_VERSION = \\"28.0.3\\"
205-
def DEFAULT_MIN_SDK_VERSION = 16
206-
def DEFAULT_TARGET_SDK_VERSION = 28
207-
208205
android {
209206
compileSdkVersion safeExtGet('compileSdkVersion', DEFAULT_COMPILE_SDK_VERSION)
210207
buildToolsVersion safeExtGet('buildToolsVersion', DEFAULT_BUILD_TOOLS_VERSION)

‎tests/with-injection/create/with-example/with-defaults/__snapshots__/create-with-example-with-defaults.test.js.snap

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,11 @@ content:
180180
--------
181181
// android/build.gradle
182182
183+
def DEFAULT_COMPILE_SDK_VERSION = 28
184+
def DEFAULT_BUILD_TOOLS_VERSION = '28.0.3'
185+
def DEFAULT_MIN_SDK_VERSION = 16
186+
def DEFAULT_TARGET_SDK_VERSION = 28
187+
183188
def safeExtGet(prop, fallback) {
184189
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
185190
}
@@ -202,14 +207,6 @@ buildscript {
202207
apply plugin: 'com.android.library'
203208
apply plugin: 'maven'
204209
205-
// Matches values in recent template from React Native 0.59 / 0.60
206-
// https://github.com/facebook/react-native/blob/0.59-stable/template/android/build.gradle#L5-L9
207-
// https://github.com/facebook/react-native/blob/0.60-stable/template/android/build.gradle#L5-L9
208-
def DEFAULT_COMPILE_SDK_VERSION = 28
209-
def DEFAULT_BUILD_TOOLS_VERSION = \\"28.0.3\\"
210-
def DEFAULT_MIN_SDK_VERSION = 16
211-
def DEFAULT_TARGET_SDK_VERSION = 28
212-
213210
android {
214211
compileSdkVersion safeExtGet('compileSdkVersion', DEFAULT_COMPILE_SDK_VERSION)
215212
buildToolsVersion safeExtGet('buildToolsVersion', DEFAULT_BUILD_TOOLS_VERSION)

‎tests/with-injection/create/with-example/with-missing-package-scripts/__snapshots__/recover-from-missing-package-scripts.test.js.snap

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,11 @@ content:
180180
--------
181181
// android/build.gradle
182182
183+
def DEFAULT_COMPILE_SDK_VERSION = 28
184+
def DEFAULT_BUILD_TOOLS_VERSION = '28.0.3'
185+
def DEFAULT_MIN_SDK_VERSION = 16
186+
def DEFAULT_TARGET_SDK_VERSION = 28
187+
183188
def safeExtGet(prop, fallback) {
184189
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
185190
}
@@ -202,14 +207,6 @@ buildscript {
202207
apply plugin: 'com.android.library'
203208
apply plugin: 'maven'
204209
205-
// Matches values in recent template from React Native 0.59 / 0.60
206-
// https://github.com/facebook/react-native/blob/0.59-stable/template/android/build.gradle#L5-L9
207-
// https://github.com/facebook/react-native/blob/0.60-stable/template/android/build.gradle#L5-L9
208-
def DEFAULT_COMPILE_SDK_VERSION = 28
209-
def DEFAULT_BUILD_TOOLS_VERSION = \\"28.0.3\\"
210-
def DEFAULT_MIN_SDK_VERSION = 16
211-
def DEFAULT_TARGET_SDK_VERSION = 28
212-
213210
android {
214211
compileSdkVersion safeExtGet('compileSdkVersion', DEFAULT_COMPILE_SDK_VERSION)
215212
buildToolsVersion safeExtGet('buildToolsVersion', DEFAULT_BUILD_TOOLS_VERSION)

‎tests/with-injection/create/with-example/with-null-options/with-null-prefix/__snapshots__/create-with-example-with-null-prefix.test.js.snap

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,11 @@ content:
180180
--------
181181
// android/build.gradle
182182
183+
def DEFAULT_COMPILE_SDK_VERSION = 28
184+
def DEFAULT_BUILD_TOOLS_VERSION = '28.0.3'
185+
def DEFAULT_MIN_SDK_VERSION = 16
186+
def DEFAULT_TARGET_SDK_VERSION = 28
187+
183188
def safeExtGet(prop, fallback) {
184189
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
185190
}
@@ -202,14 +207,6 @@ buildscript {
202207
apply plugin: 'com.android.library'
203208
apply plugin: 'maven'
204209
205-
// Matches values in recent template from React Native 0.59 / 0.60
206-
// https://github.com/facebook/react-native/blob/0.59-stable/template/android/build.gradle#L5-L9
207-
// https://github.com/facebook/react-native/blob/0.60-stable/template/android/build.gradle#L5-L9
208-
def DEFAULT_COMPILE_SDK_VERSION = 28
209-
def DEFAULT_BUILD_TOOLS_VERSION = \\"28.0.3\\"
210-
def DEFAULT_MIN_SDK_VERSION = 16
211-
def DEFAULT_TARGET_SDK_VERSION = 28
212-
213210
android {
214211
compileSdkVersion safeExtGet('compileSdkVersion', DEFAULT_COMPILE_SDK_VERSION)
215212
buildToolsVersion safeExtGet('buildToolsVersion', DEFAULT_BUILD_TOOLS_VERSION)

‎tests/with-injection/create/with-example/with-options/__snapshots__/create-with-example-with-options.test.js.snap

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,11 @@ content:
180180
--------
181181
// android/build.gradle
182182
183+
def DEFAULT_COMPILE_SDK_VERSION = 28
184+
def DEFAULT_BUILD_TOOLS_VERSION = '28.0.3'
185+
def DEFAULT_MIN_SDK_VERSION = 16
186+
def DEFAULT_TARGET_SDK_VERSION = 28
187+
183188
def safeExtGet(prop, fallback) {
184189
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
185190
}
@@ -202,14 +207,6 @@ buildscript {
202207
apply plugin: 'com.android.library'
203208
apply plugin: 'maven'
204209
205-
// Matches values in recent template from React Native 0.59 / 0.60
206-
// https://github.com/facebook/react-native/blob/0.59-stable/template/android/build.gradle#L5-L9
207-
// https://github.com/facebook/react-native/blob/0.60-stable/template/android/build.gradle#L5-L9
208-
def DEFAULT_COMPILE_SDK_VERSION = 28
209-
def DEFAULT_BUILD_TOOLS_VERSION = \\"28.0.3\\"
210-
def DEFAULT_MIN_SDK_VERSION = 16
211-
def DEFAULT_TARGET_SDK_VERSION = 28
212-
213210
android {
214211
compileSdkVersion safeExtGet('compileSdkVersion', DEFAULT_COMPILE_SDK_VERSION)
215212
buildToolsVersion safeExtGet('buildToolsVersion', DEFAULT_BUILD_TOOLS_VERSION)

‎tests/with-injection/create/with-name-in-camel-case/__snapshots__/create-with-name-in-camel-case.test.js.snap

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,11 @@ content:
175175
--------
176176
// android/build.gradle
177177
178+
def DEFAULT_COMPILE_SDK_VERSION = 28
179+
def DEFAULT_BUILD_TOOLS_VERSION = '28.0.3'
180+
def DEFAULT_MIN_SDK_VERSION = 16
181+
def DEFAULT_TARGET_SDK_VERSION = 28
182+
178183
def safeExtGet(prop, fallback) {
179184
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
180185
}
@@ -197,14 +202,6 @@ buildscript {
197202
apply plugin: 'com.android.library'
198203
apply plugin: 'maven'
199204
200-
// Matches values in recent template from React Native 0.59 / 0.60
201-
// https://github.com/facebook/react-native/blob/0.59-stable/template/android/build.gradle#L5-L9
202-
// https://github.com/facebook/react-native/blob/0.60-stable/template/android/build.gradle#L5-L9
203-
def DEFAULT_COMPILE_SDK_VERSION = 28
204-
def DEFAULT_BUILD_TOOLS_VERSION = \\"28.0.3\\"
205-
def DEFAULT_MIN_SDK_VERSION = 16
206-
def DEFAULT_TARGET_SDK_VERSION = 28
207-
208205
android {
209206
compileSdkVersion safeExtGet('compileSdkVersion', DEFAULT_COMPILE_SDK_VERSION)
210207
buildToolsVersion safeExtGet('buildToolsVersion', DEFAULT_BUILD_TOOLS_VERSION)

‎tests/with-injection/create/with-options/for-android/__snapshots__/create-with-options-for-android.test.js.snap

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,11 @@ content:
144144
--------
145145
// android/build.gradle
146146
147+
def DEFAULT_COMPILE_SDK_VERSION = 28
148+
def DEFAULT_BUILD_TOOLS_VERSION = '28.0.3'
149+
def DEFAULT_MIN_SDK_VERSION = 16
150+
def DEFAULT_TARGET_SDK_VERSION = 28
151+
147152
def safeExtGet(prop, fallback) {
148153
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
149154
}
@@ -166,14 +171,6 @@ buildscript {
166171
apply plugin: 'com.android.library'
167172
apply plugin: 'maven'
168173
169-
// Matches values in recent template from React Native 0.59 / 0.60
170-
// https://github.com/facebook/react-native/blob/0.59-stable/template/android/build.gradle#L5-L9
171-
// https://github.com/facebook/react-native/blob/0.60-stable/template/android/build.gradle#L5-L9
172-
def DEFAULT_COMPILE_SDK_VERSION = 28
173-
def DEFAULT_BUILD_TOOLS_VERSION = \\"28.0.3\\"
174-
def DEFAULT_MIN_SDK_VERSION = 16
175-
def DEFAULT_TARGET_SDK_VERSION = 28
176-
177174
android {
178175
compileSdkVersion safeExtGet('compileSdkVersion', DEFAULT_COMPILE_SDK_VERSION)
179176
buildToolsVersion safeExtGet('buildToolsVersion', DEFAULT_BUILD_TOOLS_VERSION)

0 commit comments

Comments
 (0)