update Android build tools Gradle classpath

Christopher J. Brody · friederbluemle · Christopher J. Brody · commit 8da93fd67257 · 2019-09-22T12:15:25.000-04:00
* update to `com.android.tools.build:gradle:3.5.0`
* update comments

Co-authored-by: Christopher J. Brody &lt;chris@brody.consulting&gt;
Co-authored-by: Frieder Bluemle &lt;frieder.bluemle@gmail.com&gt;
diff --git a/templates/android.js b/templates/android.js
@@ -16,7 +16,10 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            // ref:
+            // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15
+            // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google
+            classpath 'com.android.tools.build:gradle:3.5.0'
         }
     }
 }
diff --git a/tests/integration/cli/create/view/__snapshots__/cli-create-with-view.test.js.snap b/tests/integration/cli/create/view/__snapshots__/cli-create-with-view.test.js.snap
@@ -140,7 +140,10 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            // ref:
+            // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15
+            // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google
+            classpath 'com.android.tools.build:gradle:3.5.0'
         }
     }
 }
diff --git a/tests/integration/cli/create/with-defaults/__snapshots__/cli-create-with-defaults.test.js.snap b/tests/integration/cli/create/with-defaults/__snapshots__/cli-create-with-defaults.test.js.snap
@@ -140,7 +140,10 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            // ref:
+            // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15
+            // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google
+            classpath 'com.android.tools.build:gradle:3.5.0'
         }
     }
 }
diff --git a/tests/with-injection/create/view/with-defaults/__snapshots__/create-view-with-defaults.test.js.snap b/tests/with-injection/create/view/with-defaults/__snapshots__/create-view-with-defaults.test.js.snap
@@ -215,7 +215,10 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            // ref:
+            // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15
+            // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google
+            classpath 'com.android.tools.build:gradle:3.5.0'
         }
     }
 }
diff --git a/tests/with-injection/create/view/with-example/with-defaults/__snapshots__/create-view-with-example-with-defaults.test.js.snap b/tests/with-injection/create/view/with-example/with-defaults/__snapshots__/create-view-with-example-with-defaults.test.js.snap
@@ -220,7 +220,10 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            // ref:
+            // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15
+            // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google
+            classpath 'com.android.tools.build:gradle:3.5.0'
         }
     }
 }
diff --git a/tests/with-injection/create/view/with-example/with-options/__snapshots__/create-view-with-example-with-options.test.js.snap b/tests/with-injection/create/view/with-example/with-options/__snapshots__/create-view-with-example-with-options.test.js.snap
@@ -220,7 +220,10 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            // ref:
+            // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15
+            // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google
+            classpath 'com.android.tools.build:gradle:3.5.0'
         }
     }
 }
diff --git a/tests/with-injection/create/view/with-options/for-android/__snapshots__/lib-view-android-config-options.test.js.snap b/tests/with-injection/create/view/with-options/for-android/__snapshots__/lib-view-android-config-options.test.js.snap
@@ -177,7 +177,10 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            // ref:
+            // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15
+            // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google
+            classpath 'com.android.tools.build:gradle:3.5.0'
         }
     }
 }
diff --git a/tests/with-injection/create/with-defaults/__snapshots__/create-with-defaults.test.js.snap b/tests/with-injection/create/with-defaults/__snapshots__/create-with-defaults.test.js.snap
@@ -215,7 +215,10 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            // ref:
+            // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15
+            // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google
+            classpath 'com.android.tools.build:gradle:3.5.0'
         }
     }
 }
diff --git a/tests/with-injection/create/with-example/with-defaults/__snapshots__/create-with-example-with-defaults.test.js.snap b/tests/with-injection/create/with-example/with-defaults/__snapshots__/create-with-example-with-defaults.test.js.snap
@@ -220,7 +220,10 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            // ref:
+            // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15
+            // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google
+            classpath 'com.android.tools.build:gradle:3.5.0'
         }
     }
 }
diff --git a/tests/with-injection/create/with-example/with-missing-package-scripts/__snapshots__/recover-from-missing-package-scripts.test.js.snap b/tests/with-injection/create/with-example/with-missing-package-scripts/__snapshots__/recover-from-missing-package-scripts.test.js.snap
@@ -220,7 +220,10 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            // ref:
+            // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15
+            // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google
+            classpath 'com.android.tools.build:gradle:3.5.0'
         }
     }
 }
diff --git a/tests/with-injection/create/with-example/with-null-options/with-null-prefix/__snapshots__/create-with-example-with-null-prefix.test.js.snap b/tests/with-injection/create/with-example/with-null-options/with-null-prefix/__snapshots__/create-with-example-with-null-prefix.test.js.snap
@@ -220,7 +220,10 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            // ref:
+            // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15
+            // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google
+            classpath 'com.android.tools.build:gradle:3.5.0'
         }
     }
 }
diff --git a/tests/with-injection/create/with-example/with-options/__snapshots__/create-with-example-with-options.test.js.snap b/tests/with-injection/create/with-example/with-options/__snapshots__/create-with-example-with-options.test.js.snap
@@ -220,7 +220,10 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            // ref:
+            // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15
+            // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google
+            classpath 'com.android.tools.build:gradle:3.5.0'
         }
     }
 }
diff --git a/tests/with-injection/create/with-name-in-camel-case/__snapshots__/create-with-name-in-camel-case.test.js.snap b/tests/with-injection/create/with-name-in-camel-case/__snapshots__/create-with-name-in-camel-case.test.js.snap
@@ -215,7 +215,10 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            // ref:
+            // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15
+            // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google
+            classpath 'com.android.tools.build:gradle:3.5.0'
         }
     }
 }
diff --git a/tests/with-injection/create/with-options/for-android/__snapshots__/create-with-options-for-android.test.js.snap b/tests/with-injection/create/with-options/for-android/__snapshots__/create-with-options-for-android.test.js.snap
@@ -177,7 +177,10 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            // ref:
+            // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15
+            // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google
+            classpath 'com.android.tools.build:gradle:3.5.0'
         }
     }
 }
diff --git a/tests/with-injection/create/with-options/platforms-array/__snapshots__/platforms-array.test.js.snap b/tests/with-injection/create/with-options/platforms-array/__snapshots__/platforms-array.test.js.snap
@@ -215,7 +215,10 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            // ref:
+            // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15
+            // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google
+            classpath 'com.android.tools.build:gradle:3.5.0'
         }
     }
 }
diff --git a/tests/with-injection/create/with-options/platforms-comma-separated/__snapshots__/platforms-comma-separated.test.js.snap b/tests/with-injection/create/with-options/platforms-comma-separated/__snapshots__/platforms-comma-separated.test.js.snap
@@ -215,7 +215,10 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            // ref:
+            // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15
+            // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google
+            classpath 'com.android.tools.build:gradle:3.5.0'
         }
     }
 }
diff --git a/tests/with-injection/create/with-options/with-custom-module-prefix/__snapshots__/create-with-custom-module-prefix.test.js.snap b/tests/with-injection/create/with-options/with-custom-module-prefix/__snapshots__/create-with-custom-module-prefix.test.js.snap
@@ -215,7 +215,10 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            // ref:
+            // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15
+            // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google
+            classpath 'com.android.tools.build:gradle:3.5.0'
         }
     }
 }
diff --git a/tests/with-injection/create/with-options/with-module-name/__snapshots__/create-with-module-name.test.js.snap b/tests/with-injection/create/with-options/with-module-name/__snapshots__/create-with-module-name.test.js.snap
@@ -215,7 +215,10 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            // ref:
+            // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15
+            // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google
+            classpath 'com.android.tools.build:gradle:3.5.0'
         }
     }
 }
diff --git a/tests/with-mocks/cli/command/func/with-options/__snapshots__/cli-command-func-with-options.test.js.snap b/tests/with-mocks/cli/command/func/with-options/__snapshots__/cli-command-func-with-options.test.js.snap
@@ -219,7 +219,10 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            // ref:
+            // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15
+            // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google
+            classpath 'com.android.tools.build:gradle:3.5.0'
         }
     }
 }
diff --git a/tests/with-mocks/cli/program/with-defaults/for-android/__snapshots__/cli-program-with-defaults-for-android.test.js.snap b/tests/with-mocks/cli/program/with-defaults/for-android/__snapshots__/cli-program-with-defaults-for-android.test.js.snap
@@ -342,7 +342,10 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            // ref:
+            // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15
+            // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google
+            classpath 'com.android.tools.build:gradle:3.5.0'
         }
     }
 }
diff --git a/tests/with-mocks/lib/create/with-example/with-logging/with-defaults/__snapshots__/create-with-example-with-defaults.test.js.snap b/tests/with-mocks/lib/create/with-example/with-logging/with-defaults/__snapshots__/create-with-example-with-defaults.test.js.snap
@@ -284,7 +284,10 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            // ref:
+            // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15
+            // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google
+            classpath 'com.android.tools.build:gradle:3.5.0'
         }
     }
 }
diff --git a/tests/with-mocks/lib/create/with-example/with-logging/with-error/__snapshots__/with-yarn-error-logging.test.js.snap b/tests/with-mocks/lib/create/with-example/with-logging/with-error/__snapshots__/with-yarn-error-logging.test.js.snap
@@ -284,7 +284,10 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            // ref:
+            // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15
+            // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google
+            classpath 'com.android.tools.build:gradle:3.5.0'
         }
     }
 }
diff --git a/tests/with-mocks/lib/create/with-example/with-logging/with-null-options/with-null-prefix/__snapshots__/create-with-example-with-options.test.js.snap b/tests/with-mocks/lib/create/with-example/with-logging/with-null-options/with-null-prefix/__snapshots__/create-with-example-with-options.test.js.snap
@@ -284,7 +284,10 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            // ref:
+            // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15
+            // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google
+            classpath 'com.android.tools.build:gradle:3.5.0'
         }
     }
 }
diff --git a/tests/with-mocks/lib/create/with-example/with-logging/with-options/__snapshots__/create-with-example-with-options.test.js.snap b/tests/with-mocks/lib/create/with-example/with-logging/with-options/__snapshots__/create-with-example-with-options.test.js.snap
@@ -278,7 +278,10 @@ buildscript {
             jcenter()
         }
         dependencies {
-            classpath 'com.android.tools.build:gradle:3.4.1'
+            // ref:
+            // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15
+            // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google
+            classpath 'com.android.tools.build:gradle:3.5.0'
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,10 @@ buildscript {`
`16`	`16`	`jcenter()`
`17`	`17`	`}`
`18`	`18`	`dependencies {`
`19`		`- classpath 'com.android.tools.build:gradle:3.4.1'`
	`19`	`+ // ref:`
	`20`	`+ // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15`
	`21`	`+ // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google`
	`22`	`+ classpath 'com.android.tools.build:gradle:3.5.0'`
`20`	`23`	`}`
`21`	`24`	`}`
`22`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,10 @@ buildscript {`
`140`	`140`	`jcenter()`
`141`	`141`	`}`
`142`	`142`	`dependencies {`
`143`		`- classpath 'com.android.tools.build:gradle:3.4.1'`
	`143`	`+ // ref:`
	`144`	`+ // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15`
	`145`	`+ // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google`
	`146`	`+ classpath 'com.android.tools.build:gradle:3.5.0'`
`144`	`147`	`}`
`145`	`148`	`}`
`146`	`149`	`}`
Original file line number	Diff line number	Diff line change
`@@ -215,7 +215,10 @@ buildscript {`
`215`	`215`	`jcenter()`
`216`	`216`	`}`
`217`	`217`	`dependencies {`
`218`		`- classpath 'com.android.tools.build:gradle:3.4.1'`
	`218`	`+ // ref:`
	`219`	`+ // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15`
	`220`	`+ // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google`
	`221`	`+ classpath 'com.android.tools.build:gradle:3.5.0'`
`219`	`222`	`}`
`220`	`223`	`}`
`221`	`224`	`}`
Original file line number	Diff line number	Diff line change
`@@ -220,7 +220,10 @@ buildscript {`
`220`	`220`	`jcenter()`
`221`	`221`	`}`
`222`	`222`	`dependencies {`
`223`		`- classpath 'com.android.tools.build:gradle:3.4.1'`
	`223`	`+ // ref:`
	`224`	`+ // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15`
	`225`	`+ // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google`
	`226`	`+ classpath 'com.android.tools.build:gradle:3.5.0'`
`224`	`227`	`}`
`225`	`228`	`}`
`226`	`229`	`}`
Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,10 @@ buildscript {`
`177`	`177`	`jcenter()`
`178`	`178`	`}`
`179`	`179`	`dependencies {`
`180`		`- classpath 'com.android.tools.build:gradle:3.4.1'`
	`180`	`+ // ref:`
	`181`	`+ // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15`
	`182`	`+ // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google`
	`183`	`+ classpath 'com.android.tools.build:gradle:3.5.0'`
`181`	`184`	`}`
`182`	`185`	`}`
`183`	`186`	`}`
Original file line number	Diff line number	Diff line change
`@@ -219,7 +219,10 @@ buildscript {`
`219`	`219`	`jcenter()`
`220`	`220`	`}`
`221`	`221`	`dependencies {`
`222`		`- classpath 'com.android.tools.build:gradle:3.4.1'`
	`222`	`+ // ref:`
	`223`	`+ // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15`
	`224`	`+ // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google`
	`225`	`+ classpath 'com.android.tools.build:gradle:3.5.0'`
`223`	`226`	`}`
`224`	`227`	`}`
`225`	`228`	`}`
Original file line number	Diff line number	Diff line change
`@@ -342,7 +342,10 @@ buildscript {`
`342`	`342`	`jcenter()`
`343`	`343`	`}`
`344`	`344`	`dependencies {`
`345`		`- classpath 'com.android.tools.build:gradle:3.4.1'`
	`345`	`+ // ref:`
	`346`	`+ // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15`
	`347`	`+ // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google`
	`348`	`+ classpath 'com.android.tools.build:gradle:3.5.0'`
`346`	`349`	`}`
`347`	`350`	`}`
`348`	`351`	`}`
Original file line number	Diff line number	Diff line change
`@@ -284,7 +284,10 @@ buildscript {`
`284`	`284`	`jcenter()`
`285`	`285`	`}`
`286`	`286`	`dependencies {`
`287`		`- classpath 'com.android.tools.build:gradle:3.4.1'`
	`287`	`+ // ref:`
	`288`	`+ // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15`
	`289`	`+ // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google`
	`290`	`+ classpath 'com.android.tools.build:gradle:3.5.0'`
`288`	`291`	`}`
`289`	`292`	`}`
`290`	`293`	`}`
Original file line number	Diff line number	Diff line change
`@@ -278,7 +278,10 @@ buildscript {`
`278`	`278`	`jcenter()`
`279`	`279`	`}`
`280`	`280`	`dependencies {`
`281`		`- classpath 'com.android.tools.build:gradle:3.4.1'`
	`281`	`+ // ref:`
	`282`	`+ // * https://github.com/facebook/react-native/blob/0.61-stable/template/android/build.gradle#L15`
	`283`	`+ // * https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google`
	`284`	`+ classpath 'com.android.tools.build:gradle:3.5.0'`
`282`	`285`	`}`
`283`	`286`	`}`
`284`	`287`	`}`