Skip to content

Commit c0a748d

Browse files
authored
Merge pull request #953 from browserstack/HST-1918-fix-status-code
Add error exit code on failure
2 parents e3f7ea2 + bff0ed6 commit c0a748d

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

bin/commands/runs.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -365,10 +365,10 @@ module.exports = function run(args, rawArgs) {
365365
}
366366

367367
// Generate custom report!
368-
reportGenerator(bsConfig, data.build_id, args, rawArgs, buildReportData, function(){
368+
reportGenerator(bsConfig, data.build_id, args, rawArgs, buildReportData, function(modifiedExitCode=exitCode){
369369
utils.sendUsageReport(bsConfig, args, `${message}\n${dashboardLink}`, Constants.messageTypes.SUCCESS, null, buildReportData, rawArgs);
370370
markBlockEnd('postBuild');
371-
utils.handleSyncExit(exitCode, data.dashboard_url);
371+
utils.handleSyncExit(modifiedExitCode, data.dashboard_url);
372372
});
373373
} else if(!turboScaleSession){
374374
let stacktraceUrl = getStackTraceUrl();

bin/helpers/reporterHTML.js

+3
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,9 @@ let reportGenerator = async (bsConfig, buildId, args, rawArgs, buildReportData,
105105
logger.error('Generating the build report failed.');
106106
logger.error(utils.formatRequest(error.response.statusText, error.response, error.response.data));
107107
utils.sendUsageReport(bsConfig, args, message, messageType, errorCode, buildReportData, rawArgs);
108+
if (cb){
109+
cb(Constants.ERROR_EXIT_CODE);
110+
}
108111
return;
109112
}
110113
}

0 commit comments

Comments
 (0)