fix: flow

Author: bufferoverflow

.vscode/settings.json

@@ -1,3 +1,3 @@
 {
     "javascript.validate.enable": false
-}
+}

README.md

@@ -28,6 +28,8 @@ npm install
 npm start
 ```
 
+> **NOTE**: Define `http_proxy` environment variable if you are behind a proxy.
+
 verdaccio is now up and running, now configure the following within
 your `~/.config/verdaccio/config.yaml` to use this plugin
 

package-lock.json

@@ -43,7 +43,9 @@
     "node": ">=6.12.0"
   },
   "dependencies": {
+    "@verdaccio/types": "^3.0.0",
     "gitlab": "^3.4.2",
+    "global-tunnel-ng": "^2.1.1",
     "verdaccio": "^3.1.1"
   },
   "devDependencies": {
@@ -55,7 +57,7 @@
     "babel-preset-flow": "^6.23.0",
     "eclint": "^2.5.0",
     "eslint": "^4.19.1",
-    "flow-bin": "^0.74.0",
+    "flow-bin": "^0.75.0",
     "flow-runtime": "^0.17.0",
     "generate-changelog": "^1.7.0",
     "husky": "^0.14.3",

package.json

@@ -4,22 +4,14 @@
 
 import Gitlab from 'gitlab';
 import {httperror} from 'http-errors';
-import type {Config, Logger, Callback} from '@verdaccio/types';
+import type { PackageAccess, Config, Logger, Callback } from '@verdaccio/types';
 
-export default class GitLab {
-  /**
-   *
-   * @param {*} config 
-   * @param {object} stuff config.yaml in object from
-   */
-
-  // flow types
+export default class VerdaccioGitLab {
   users: {};
   stuff: {};
-  config: Config;
+  config: {};
   logger: Logger;
 
-  // constructor
   constructor(
     config: {
       url: string
@@ -33,84 +25,81 @@ export default class GitLab {
   ) {
     this.users = {};
 
-    // config for this module
     this.config = config;
     this.stuff = stuff;
 
-    // verdaccio logger
     this.logger = stuff.logger;
 
   }
 
-authenticate(user: string, password: string, cb: Callback) {
+  authenticate(user: string, password: string, cb: Callback) {
 
-  var GitlabAPI = new Gitlab({
-    url:   this.config.url,
-    token: password
-  });
+    var GitlabAPI = new Gitlab({
+      url:   this.config.url,
+      token: password
+    });
 
-  GitlabAPI.Users.current().then((response) => {
-    if (user !== response.username) return cb(httperror[403]('wrong gitlab username'));
-    var ownedGroups = [user];
-    GitlabAPI.Groups.all({'owned': 'true'}).then((groups) => {
-      groups.forEach(function(item) {
-        if (item.path === item.full_path) {
-          ownedGroups.push(item.path);
-        }
+    GitlabAPI.Users.current().then((response) => {
+      if (user !== response.username) return cb(httperror[403]('wrong gitlab username'));
+      var ownedGroups = [user];
+      GitlabAPI.Groups.all({'owned': 'true'}).then((groups) => {
+        groups.forEach(function(item) {
+          if (item.path === item.full_path) {
+            ownedGroups.push(item.path);
+          }
+        });
+        cb(null, ownedGroups);
       });
-      cb(null, ownedGroups);
+    }).
+    catch(error => {
+      if (error) return cb('Personal access token invalid');
     });
-  }).
-  catch(error => {
-    if (error) return cb('Personal access token invalid');
-  });
-}
+  }
 
-adduser(user: string, password: string, cb: Callback) {
-  cb(null, false);
-}
+  adduser(user: string, password: string, cb: Callback) {
+    cb(null, false);
+  }
 
-allow_access(user: string, _package: string , cb: Callback) {
-  if (!_package.gitlab) return cb();
-  if (_package.access.includes('$authenticated') && user.name !== undefined) {
-    return cb(null, true);
-  } else {
-    return cb(null, false);
+  allow_access(user, _package:  PackageAccess, cb: Callback) {
+    if (!_package.gitlab) return cb();
+    if (_package.access.includes('$authenticated') && user.name !== undefined) {
+      return cb(null, true);
+    } else {
+      return cb(null, false);
+    }
   }
-}
 
-allow_publish(user: string, _package: string, cb: Callback) { // jscs:ignore requireCamelCaseOrUpperCaseIdentifiers
-  if (!_package.gitlab) return cb();
-  var packageScopeOwner = false;
-  var packageOwner = false;
+  allow_publish(user, _package: PackageAccess, cb: Callback) { // jscs:ignore requireCamelCaseOrUpperCaseIdentifiers
+    if (!_package.gitlab) return cb();
+    var packageScopeOwner = false;
+    var packageOwner = false;
 
-  user.real_groups.forEach(function(item) { // jscs:ignore requireCamelCaseOrUpperCaseIdentifiers
-    if (item === _package.name) {
-      packageOwner = true;
-      return false;
-    } else {
-      if (_package.name.indexOf('@') === 0) {
-        if (item === _package.name.slice(1, _package.name.lastIndexOf('/'))) {
-          packageScopeOwner = true;
-          return false;
+    user.real_groups.forEach(function(item) { // jscs:ignore requireCamelCaseOrUpperCaseIdentifiers
+      if (item === _package.name) {
+        packageOwner = true;
+        return false;
+      } else {
+        if (_package.name.indexOf('@') === 0) {
+          if (item === _package.name.slice(1, _package.name.lastIndexOf('/'))) {
+            packageScopeOwner = true;
+            return false;
+          }
         }
       }
-    }
-  });
+    });
 
-  if (packageOwner === true) {
-    return cb(null, false);
-  } else {
-    if (packageScopeOwner === true) {
+    if (packageOwner === true) {
       return cb(null, false);
     } else {
-      if (_package.name.indexOf('@') === 0) {
-        return cb(httperror[403]('must be owner of package-scope'));
+      if (packageScopeOwner === true) {
+        return cb(null, false);
       } else {
-        return cb(httperror[403]('must be owner of package-name'));
+        if (_package.name.indexOf('@') === 0) {
+          return cb(httperror[403]('must be owner of package-scope'));
+        } else {
+          return cb(httperror[403]('must be owner of package-name'));
+        }
       }
     }
   }
 }
-
-}

src/gitlab.js

@@ -1,13 +1,7 @@
 // Copyright 2018 Roger Meier <[email protected]>
 // SPDX-License-Identifier: MIT
-import GitLab from './gitlab';
+import VerdaccioGitLab from './gitlab';
 
-/**
- * A new instance of HTPasswd class.
- * @param {object} config
- * @param {object} stuff
- * @returns {object}
- */
 export default function(config, stuff) {
-  return new GitLab(config, stuff);
+  return new VerdaccioGitLab(config, stuff);
 }

src/index.js

@@ -1 +1,3 @@
+const globalTunnel = require('global-tunnel-ng');
+globalTunnel.initialize();
 require('verdaccio/build/lib/cli');