nogo: add missing go vet checks

Remove usage of `vet = True` in nogo definition. It's simply a shortcut
attribute to appends some additional analyzers to the nogo binary.

Instead, run `go tool vet help` and copy all listed analyzers in the doc
to our analyzer. This list is more up-to-date than the one in current
rules_go.

Fix 2 vet issues found with new analyzers added:

- Misuse of unbuffered os.Signal channel as argument to signal.Notify
  The channel should be buffered with minimal size of 1.

- time.Since should not be used in defer statement
  See golang/go#60048 for more information

Author: sluongng

BUILD

@@ -35,32 +35,42 @@ write_file(
                     },
                 }
                 for analyzer in ANALYZERS + [
+                    "appends",
                     "asmdecl",
                     "assign",
                     "atomicalign",
+                    "bools",
                     "buildtag",
-                    "cgocall",
+                    # "cgocall",
                     "composites",
                     "copylocks",
                     "deepequalerrors",
+                    "defers",
+                    "directive",
                     "errorsas",
+                    # Noisy and is not part of 'go vet'
                     # "fieldalignment",
                     "framepointer",
                     "httpresponse",
                     "ifaceassert",
                     "loopclosure",
                     "lostcancel",
+                    "nilfunc",
                     # template methods currently cause this analyzer to panic
                     # "nilness",
+                    "printf",
                     # Everyone shadows `err`
                     # "shadow",
                     "shift",
+                    "sigchanyzer",
+                    "slog",
                     "sortslice",
                     "stdmethods",
                     "stringintconv",
                     "structtag",
-                    "tests",
                     "testinggoroutine",
+                    "tests",
+                    "timeformat",
                     "unmarshal",
                     "unreachable",
                     "unsafeptr",
@@ -74,34 +84,44 @@ write_file(
 nogo(
     name = "vet",
     config = ":nogo_config.json",
-    vet = True,
     visibility = ["//visibility:public"],
     deps = [
+        "@org_golang_x_tools//go/analysis/passes/appends",
         "@org_golang_x_tools//go/analysis/passes/asmdecl",
         "@org_golang_x_tools//go/analysis/passes/assign",
+        "@org_golang_x_tools//go/analysis/passes/atomic",
         "@org_golang_x_tools//go/analysis/passes/atomicalign",
+        "@org_golang_x_tools//go/analysis/passes/bools",
+        "@org_golang_x_tools//go/analysis/passes/buildtag",
         # "@org_golang_x_tools//go/analysis/passes/cgocall",
         "@org_golang_x_tools//go/analysis/passes/composite",
         "@org_golang_x_tools//go/analysis/passes/copylock",
         "@org_golang_x_tools//go/analysis/passes/deepequalerrors",
+        "@org_golang_x_tools//go/analysis/passes/defers",
+        "@org_golang_x_tools//go/analysis/passes/directive",
         "@org_golang_x_tools//go/analysis/passes/errorsas",
         # "@org_golang_x_tools//go/analysis/passes/fieldalignment",
         "@org_golang_x_tools//go/analysis/passes/framepointer",
         "@org_golang_x_tools//go/analysis/passes/httpresponse",
         "@org_golang_x_tools//go/analysis/passes/ifaceassert",
         "@org_golang_x_tools//go/analysis/passes/loopclosure",
         "@org_golang_x_tools//go/analysis/passes/lostcancel",
+        "@org_golang_x_tools//go/analysis/passes/nilfunc",
         # template methods currently cause this analyzer to panic
         # "@org_golang_x_tools//go/analysis/passes/nilness",
+        "@org_golang_x_tools//go/analysis/passes/printf",
         # Everyone shadows `err`
         # "@org_golang_x_tools//go/analysis/passes/shadow",
         "@org_golang_x_tools//go/analysis/passes/shift",
+        "@org_golang_x_tools//go/analysis/passes/sigchanyzer",
+        "@org_golang_x_tools//go/analysis/passes/slog",
         "@org_golang_x_tools//go/analysis/passes/sortslice",
         "@org_golang_x_tools//go/analysis/passes/stdmethods",
         "@org_golang_x_tools//go/analysis/passes/stringintconv",
         "@org_golang_x_tools//go/analysis/passes/structtag",
-        "@org_golang_x_tools//go/analysis/passes/tests",
         "@org_golang_x_tools//go/analysis/passes/testinggoroutine",
+        "@org_golang_x_tools//go/analysis/passes/tests",
+        "@org_golang_x_tools//go/analysis/passes/timeformat",
         "@org_golang_x_tools//go/analysis/passes/unmarshal",
         "@org_golang_x_tools//go/analysis/passes/unreachable",
         "@org_golang_x_tools//go/analysis/passes/unsafeptr",

cli/remotebazel/remotebazel.go

@@ -679,7 +679,7 @@ func Run(ctx context.Context, opts RunOpts, repoConfig *RepoConfig) (int, error)
 	log.Debugf("Invocation ID: %s", iid)
 
 	// If the remote bazel process is canceled or killed, cancel the remote run
-	sigChan := make(chan os.Signal)
+	sigChan := make(chan os.Signal, 1)
 	go func() {
 		<-sigChan
 		_, err = bbClient.CancelExecutions(ctx, &inpb.CancelExecutionsRequest{

enterprise/server/remote_execution/soci_store/soci_store_linux.go

@@ -278,9 +278,11 @@ func streamingStoreArg(path string) string {
 
 func getArtifacts(ctx context.Context, client socipb.SociArtifactStoreClient, env environment.Env, image string, credentials oci.Credentials) error {
 	startTime := time.Now()
-	defer metrics.PodmanGetSociArtifactsLatencyUsec.
-		With(prometheus.Labels{metrics.ContainerImageTag: image}).
-		Observe(float64(time.Since(startTime).Microseconds()))
+	defer func() {
+		metrics.PodmanGetSociArtifactsLatencyUsec.
+			With(prometheus.Labels{metrics.ContainerImageTag: image}).
+			Observe(float64(time.Since(startTime).Microseconds()))
+	}()
 
 	ctx, err := prefix.AttachUserPrefixToContext(ctx, env)
 	if err != nil {

server/util/healthcheck/healthcheck.go

@@ -66,7 +66,7 @@ func NewHealthChecker(serverType string) *HealthChecker {
 		checkers:      make(map[string]interfaces.Checker, 0),
 		lastStatus:    make([]*serviceStatus, 0),
 	}
-	sigTerm := make(chan os.Signal)
+	sigTerm := make(chan os.Signal, 1)
 	go func() {
 		<-sigTerm
 		hc.Shutdown()