Skip to content

Commit 34f768d

Browse files
authored
Temporarily remove support for interface types (#1292)
* Temporarily remove support for interface types This commit temporarily removes support for interface types from the `wasmtime` CLI and removes the `wasmtime-interface-types` crate. An error is now printed for any input wasm modules that have wasm interface types sections to indicate that support has been removed and references to two issues are printed as well: * #677 - tracking work for re-adding interface types support * #1271 - rationale for removal and links to other discussions Closes #1271 * Update the python extension
1 parent 6e55c54 commit 34f768d

File tree

20 files changed

+113
-734
lines changed

20 files changed

+113
-734
lines changed

Cargo.lock

Lines changed: 0 additions & 18 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ doc = false
2626
wasmtime = { path = "crates/api" }
2727
wasmtime-debug = { path = "crates/debug" }
2828
wasmtime-environ = { path = "crates/environ" }
29-
wasmtime-interface-types = { path = "crates/interface-types" }
3029
wasmtime-jit = { path = "crates/jit" }
3130
wasmtime-obj = { path = "crates/obj" }
3231
wasmtime-profiling = { path = "crates/profiling" }

crates/api/src/module.rs

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -418,6 +418,28 @@ impl Module {
418418
}
419419
}
420420
}
421+
SectionCode::Custom {
422+
name: "webidl-bindings",
423+
..
424+
}
425+
| SectionCode::Custom {
426+
name: "wasm-interface-types",
427+
..
428+
} => {
429+
bail!(
430+
"\
431+
support for interface types has temporarily been removed from `wasmtime`
432+
433+
for more information about this temoprary you can read on the issue online:
434+
435+
https://github.com/bytecodealliance/wasmtime/issues/1271
436+
437+
and for re-adding support for interface types you can see this issue:
438+
439+
https://github.com/bytecodealliance/wasmtime/issues/677
440+
"
441+
);
442+
}
421443
_ => {
422444
// skip other sections
423445
}

crates/interface-types/Cargo.toml

Lines changed: 0 additions & 25 deletions
This file was deleted.

crates/interface-types/README.md

Lines changed: 0 additions & 4 deletions
This file was deleted.

0 commit comments

Comments
 (0)