Skip to content

Commit e6edcc2

Browse files
authored
Remove obsolete test exclusions. (#353)
async-functions.wit, host.wit, wasi-next.wit, and resource.wit are no longer in the tree, so we no longer need to explicitly disable testing them. And add the comment about disabling tests to all the codegen tests, so that it's easy to find by people debugging them.
1 parent 142b10f commit e6edcc2

File tree

6 files changed

+47
-49
lines changed

6 files changed

+47
-49
lines changed

crates/gen-guest-c/tests/codegen.rs

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,26 +2,27 @@ use std::env;
22
use std::path::{Path, PathBuf};
33
use std::process::Command;
44

5+
#[rustfmt::skip]
56
mod imports {
67
test_helpers::codegen_c_import!(
78
"*.wit"
89

9-
// TODO: implement async support
10-
"!async-functions.wit"
10+
// If you want to exclude a specific test you can include it here with
11+
// gitignore glob syntax:
12+
//
13+
// "!wasm.wit"
14+
// "!host.wit"
15+
//
16+
//
17+
// Similarly you can also just remove the `*.wit` glob and list tests
18+
// individually if you're debugging.
1119
);
1220
}
1321

22+
#[rustfmt::skip]
1423
mod exports {
1524
test_helpers::codegen_c_export!(
1625
"*.wit"
17-
18-
// TODO: implement async support
19-
"!async-functions.wit"
20-
21-
// TODO: these use push/pull buffer in exports which isn't implemented
22-
// yet
23-
"!wasi-next.wit"
24-
"!host.wit"
2526
);
2627
}
2728

crates/gen-guest-rust/tests/codegen.rs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,9 @@ mod imports {
2020
);
2121
}
2222

23+
#[rustfmt::skip]
2324
mod exports {
2425
test_helpers::codegen_rust_wasm_export!(
2526
"*.wit"
26-
27-
// TODO: these use push/pull buffer which isn't implemented in the test
28-
// generator just yet
29-
"!wasi-next.wit"
30-
"!host.wit"
3127
);
3228
}

crates/gen-guest-teavm-java/tests/codegen.rs

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,27 @@
11
use heck::{ToSnakeCase, ToUpperCamelCase};
22
use std::{fs, path::Path, process::Command};
33

4+
#[rustfmt::skip]
45
mod imports {
56
test_helpers::codegen_teavm_java_import!(
67
"*.wit"
78

8-
// TODO: implement async and resource support
9-
"!async-functions.wit"
10-
"!resource.wit"
9+
// If you want to exclude a specific test you can include it here with
10+
// gitignore glob syntax:
11+
//
12+
// "!wasm.wit"
13+
// "!host.wit"
14+
//
15+
//
16+
// Similarly you can also just remove the `*.wit` glob and list tests
17+
// individually if you're debugging.
1118
);
1219
}
1320

21+
#[rustfmt::skip]
1422
mod exports {
1523
test_helpers::codegen_teavm_java_export!(
1624
"*.wit"
17-
18-
// TODO: implement async and resource support
19-
"!async-functions.wit"
20-
"!resource.wit"
2125
);
2226
}
2327

crates/gen-host-js/tests/codegen.rs

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,27 @@
11
use std::path::Path;
22
use std::process::Command;
33

4+
#[rustfmt::skip]
45
mod exports {
56
test_helpers::codegen_js_export!(
6-
// ...
77
"*.wit"
8+
9+
// If you want to exclude a specific test you can include it here with
10+
// gitignore glob syntax:
11+
//
12+
// "!wasm.wit"
13+
// "!host.wit"
14+
//
15+
//
16+
// Similarly you can also just remove the `*.wit` glob and list tests
17+
// individually if you're debugging.
818
);
919
}
1020

21+
#[rustfmt::skip]
1122
mod imports {
1223
test_helpers::codegen_js_import!(
1324
"*.wit"
14-
15-
// This uses buffers, which we don't support in imports just yet
16-
// TODO: should support this
17-
"!wasi-next.wit"
18-
"!host.wit"
1925
);
2026
}
2127

crates/gen-host-wasmtime-py/tests/codegen.rs

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,27 @@
11
use std::path::Path;
22
use std::process::Command;
33

4+
#[rustfmt::skip]
45
mod exports {
56
test_helpers::codegen_py_export!(
67
"*.wit"
78

8-
// TODO: implement async support
9-
"!async-functions.wit"
9+
// If you want to exclude a specific test you can include it here with
10+
// gitignore glob syntax:
11+
//
12+
// "!wasm.wit"
13+
// "!host.wit"
14+
//
15+
//
16+
// Similarly you can also just remove the `*.wit` glob and list tests
17+
// individually if you're debugging.
1018
);
1119
}
1220

21+
#[rustfmt::skip]
1322
mod imports {
1423
test_helpers::codegen_py_import!(
1524
"*.wit"
16-
17-
// TODO: implement async support
18-
"!async-functions.wit"
19-
20-
// This uses buffers, which we don't support in imports just yet
21-
// TODO: should support this
22-
"!wasi-next.wit"
23-
"!host.wit"
2425
);
2526
}
2627

crates/gen-host-wasmtime-rust/tests/codegen.rs

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@ mod exports {
99
test_helpers::codegen_wasmtime_export!(
1010
"*.wit"
1111

12-
// TODO: implement async support
13-
"!async-functions.wit"
14-
1512
// If you want to exclude a specific test you can include it here with
1613
// gitignore glob syntax:
1714
//
@@ -24,17 +21,10 @@ mod exports {
2421
);
2522
}
2623

24+
#[rustfmt::skip]
2725
mod imports {
2826
test_helpers::codegen_wasmtime_import!(
2927
"*.wit"
30-
31-
// TODO: implement async support
32-
"!async-functions.wit"
33-
34-
// TODO: these use push/pull buffer which isn't implemented in the test
35-
// generator just yet
36-
"!wasi-next.wit"
37-
"!host.wit"
3828
);
3929
}
4030

0 commit comments

Comments
 (0)