🌱 (chore): use octal notation for file and directory modes (kubernetes-sigs#4663)

chore: use octal notation for file and directory modes

Replaced legacy octal literals (e.g., 0644, 0755) with Go 1.13+ `0o` syntax (e.g., 0o644, 0o755)
across the codebase. This modernizes permission mode expressions, aligns with current Go style and
guidelines.

Author: kersten

hack/docs/internal/cronjob-tutorial/generate_cronjob.go

@@ -656,7 +656,7 @@ func (sp *Sample) updateExample() {
 
 func (sp *Sample) addControllerTest() {
 	var fs = afero.NewOsFs()
-	err := afero.WriteFile(fs, filepath.Join(sp.ctx.Dir, "internal/controller/cronjob_controller_test.go"), []byte(controllerTest), 0600)
+	err := afero.WriteFile(fs, filepath.Join(sp.ctx.Dir, "internal/controller/cronjob_controller_test.go"), []byte(controllerTest), 0o600)
 	hackutils.CheckError("adding cronjob_controller_test", err)
 }
 

pkg/cli/alpha/internal/generate.go

@@ -133,7 +133,7 @@ func loadProjectConfig(inputDir string) (store.Store, error) {
 
 // Helper function to create the output directory.
 func createDirectory(outputDir string) error {
-	if err := os.MkdirAll(outputDir, 0755); err != nil {
+	if err := os.MkdirAll(outputDir, 0o755); err != nil {
 		return fmt.Errorf("failed to create output directory %s: %w", outputDir, err)
 	}
 	return nil
@@ -414,7 +414,7 @@ func copyFile(src, des string) error {
 	if err != nil {
 		return fmt.Errorf("source file path %s does not exist: %w", src, err)
 	}
-	return os.WriteFile(des, bytesRead, 0755)
+	return os.WriteFile(des, bytesRead, 0o755)
 }
 
 // Migrates Grafana configuration files.

pkg/cli/cmd_helpers.go

@@ -366,7 +366,7 @@ func updateProjectFileForAlphaGenerate() error {
 
 	// Only update the file if changes were made
 	if updated {
-		err = os.WriteFile(projectFilePath, []byte(projectStr), 0644)
+		err = os.WriteFile(projectFilePath, []byte(projectStr), 0o644)
 		if err != nil {
 			return fmt.Errorf("failed to update PROJECT file: %w", err)
 		}

pkg/cli/options.go

@@ -329,5 +329,5 @@ func DiscoverExternalPlugins(fs afero.Fs) (ps []plugin.Plugin, err error) {
 
 // isPluginExectuable checks if a plugin is an executable based on the bitmask and returns true or false.
 func isPluginExectuable(mode fs.FileMode) bool {
-	return mode&0111 != 0
+	return mode&0o111 != 0
 }

pkg/cli/options_test.go

@@ -126,7 +126,7 @@ var _ = Describe("Discover external plugins", func() {
 
 		When("using the custom path", func() {
 			BeforeEach(func() {
-				err := os.MkdirAll(customPath, 0750)
+				err := os.MkdirAll(customPath, 0o750)
 				Expect(err).ToNot(HaveOccurred())
 
 				// store and set the EXTERNAL_PLUGINS_PATH

pkg/config/store/yaml/store.go

@@ -144,7 +144,7 @@ func (s yamlStore) SaveTo(path string) error {
 	content = append([]byte(commentStr), content...)
 
 	// Write the marshalled configuration
-	err = afero.WriteFile(s.fs, path, content, 0600)
+	err = afero.WriteFile(s.fs, path, content, 0o600)
 	if err != nil {
 		return store.SaveError{Err: fmt.Errorf("failed to save configuration to %q: %w", path, err)}
 	}

pkg/machinery/scaffold.go

@@ -35,8 +35,8 @@ import (
 const (
 	createOrUpdate = os.O_WRONLY | os.O_CREATE | os.O_TRUNC
 
-	defaultDirectoryPermission os.FileMode = 0700
-	defaultFilePermission      os.FileMode = 0600
+	defaultDirectoryPermission os.FileMode = 0o700
+	defaultFilePermission      os.FileMode = 0o600
 )
 
 var options = imports.Options{

pkg/plugin/util/util.go

@@ -75,7 +75,7 @@ func InsertCode(filename, target, code string) error {
 	}
 	out := string(contents[:idx+len(target)]) + code + string(contents[idx+len(target):])
 	//nolint:gosec // false positive
-	return os.WriteFile(filename, []byte(out), 0644)
+	return os.WriteFile(filename, []byte(out), 0o644)
 }
 
 // InsertCodeIfNotExist insert code if it does not already exists
@@ -110,7 +110,7 @@ func AppendCodeIfNotExist(filename, code string) error {
 
 // AppendCodeAtTheEnd appends the given code at the end of the file.
 func AppendCodeAtTheEnd(filename, code string) error {
-	f, err := os.OpenFile(filename, os.O_APPEND|os.O_WRONLY, 0644)
+	f, err := os.OpenFile(filename, os.O_APPEND|os.O_WRONLY, 0o644)
 	if err != nil {
 		return err
 	}
@@ -168,7 +168,7 @@ func UncommentCode(filename, target, prefix string) error {
 		return err
 	}
 	//nolint:gosec // false positive
-	return os.WriteFile(filename, out.Bytes(), 0644)
+	return os.WriteFile(filename, out.Bytes(), 0o644)
 }
 
 // CommentCode searches for target in the file and adds the comment prefix
@@ -210,7 +210,7 @@ func CommentCode(filename, target, prefix string) error {
 	}
 
 	// Write the modified content back to the file
-	return os.WriteFile(filename, out.Bytes(), 0644)
+	return os.WriteFile(filename, out.Bytes(), 0o644)
 }
 
 // EnsureExistAndReplace check if the content exists and then do the replace

pkg/plugin/util/util_test.go

@@ -30,11 +30,11 @@ var _ = Describe("Cover plugin util helpers", func() {
 		var content []byte
 
 		BeforeAll(func() {
-			err := os.MkdirAll("testdata", 0755)
+			err := os.MkdirAll("testdata", 0o755)
 			Expect(err).NotTo(HaveOccurred())
 
 			if _, err := os.Stat(path); os.IsNotExist(err) {
-				err = os.WriteFile(path, []byte("exampleTarget"), 0644)
+				err = os.WriteFile(path, []byte("exampleTarget"), 0o644)
 				Expect(err).NotTo(HaveOccurred())
 			}
 
@@ -43,7 +43,7 @@ var _ = Describe("Cover plugin util helpers", func() {
 		})
 
 		AfterAll(func() {
-			err := os.WriteFile(path, content, 0644)
+			err := os.WriteFile(path, content, 0o644)
 			Expect(err).NotTo(HaveOccurred())
 
 			err = os.RemoveAll("testdata")

pkg/plugins/golang/v4/scaffolds/edit.go

@@ -66,7 +66,7 @@ func (s *editScaffolder) Scaffold() error {
 	// because there is nothing to replace.
 	if str != "" {
 		// TODO: instead of writing it directly, we should use the scaffolding machinery for consistency
-		return afero.WriteFile(s.fs.FS, filename, []byte(str), 0644)
+		return afero.WriteFile(s.fs.FS, filename, []byte(str), 0o644)
 	}
 
 	return nil

test/e2e/utils/webhooks.go

@@ -74,5 +74,5 @@ func ImplementWebhooks(filename, lowerKind string) error {
 		return err
 	}
 	//nolint:gosec // false positive
-	return os.WriteFile(filename, []byte(str), 0644)
+	return os.WriteFile(filename, []byte(str), 0o644)
 }