Skip to content

Migrate off CRA #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
squidsoup opened this issue Aug 3, 2020 · 0 comments · Fixed by #244
Closed

Migrate off CRA #199

squidsoup opened this issue Aug 3, 2020 · 0 comments · Fixed by #244
Assignees
@huwshimi
Labels
Priority: High

Comments

@squidsoup
Copy link
Contributor

react-components was initially bootstrapped with CRA. While this has been serving us well until now, CRA has an unfortunate behaviour that overwrites tsconfig in a way that is undesirable for us. Running react-scripts will currently always touch tsconfig, which is a nuisance and could lead to an invalid tsconfig being unintentionally committed.

Fortunately we do not use CRA for our build process, but the following will need to migrated:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@huwshimi huwshimi

Labels
Priority: High
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove create-react-app huwshimi/react-components
2 participants
@squidsoup @huwshimi