Implementation for HAProxy backend (#13)

* Initial scaffold for HAProxy backend

* Replace HAProxy API module

* Change to my own haproxy client module. Add test

* Implement HAProxy monitor and pool management

* Update HAProxy test

* Use validateCerts field. Fix some tests.

* Set default values and validation for validatecerts and debug on haproxy

* Improve makefile

* Use LBMethod on HAProxy

* Add HAProxy loading and validation to CRD

* Clean tests

* Make IP field minlength=1 since in HAproxy one can use *

* Open and close provider connection when finalizing to delete resources

* Implement HAProxy actions. Add tests.

* Add HAProxy docs, config and docker-compose

* Additional tests for HAProxy

* Disable some tests that fail due our mock server

* Re-enable secret test. No need to order HAProxy tests

Author: carlosedp

Diff for: Makefile

@@ -239,7 +239,7 @@ catalog-push: catalog-build ## Push a catalog image.
 	$(MAKE) docker-push IMG=$(CATALOG_IMG)
 
 .PHONY: olm-validate
-olm-validate: bundle-push ## Validates the bundle image.
+olm-validate: bundle-push catalog-push ## Validates the bundle image.
 	operator-sdk bundle validate $(BUNDLE_IMG)
 
 .PHONY: olm-run
@@ -250,23 +250,27 @@ else
 	$(shell kind create cluster --name test-operator)
 endif
 	kubectl config use-context kind-test-operator
-	operator-sdk olm install --timeout=5m || true
+	operator-sdk olm install --version=0.21.2 --timeout=5m || true
 	operator-sdk run bundle $(BUNDLE_IMG) --timeout=5m
-	kubectl create secret generic dummy-creds --from-literal=username=nsroot --from-literal=password=nsroot
+	kubectl create secret generic dummy-creds --from-literal=username=admin --from-literal=password=admin
 	kubectl apply -f config/samples/lb_v1_externalloadbalancer-dummy.yaml
+	sleep 3
 	kubectl get elb externalloadbalancer-master-dummy-test
 	operator-sdk cleanup lbconfig-operator
-	kubectl delete secret generic dummy-creds
+	kubectl delete secret dummy-creds
 	@echo "===================="
 	@echo "Don't forget to teardown the KIND cluster with 'kind delete cluster --name test-operator'"
 	@echo "===================="
 
 .PHONY: scorecard-run
 scorecard-run: ## Runs the scorecard validation (depends on a KIND cluster)
 	operator-sdk run bundle $(BUNDLE_IMG) --timeout=5m || true
-	kubectl create namespace lbconfig-operator-system || true
-	kubectl create secret generic -n lbconfig-operator-system dummy-creds --from-literal=username=admin --from-literal=password=admin || true
-	operator-sdk scorecard ./bundle  --wait-time 5m --service-account=lbconfig-operator-controller-manager --namespace=lbconfig-operator-system
+	kubectl create secret generic dummy-creds --from-literal=username=admin --from-literal=password=admin || true
+	operator-sdk scorecard ./bundle  --wait-time 5m --service-account=lbconfig-operator-controller-manager
+
+.PHONY: testenv-teardown
+testenv-teardown:
+	kind delete cluster --name test-operator
 
 .PHONY: dist
-dist: docker-cross deployment-manifests bundle-push catalog-push  ## Build manifests and container image, pushing it to the registry
+dist: docker-cross bundle olm-validate  ## Build manifests and container image, pushing it to the registry

Diff for: apis/externalloadbalancer/v1/externalloadbalancer_types.go

@@ -61,7 +61,7 @@ type ExternalLoadBalancerSpec struct {
 	// Vip is the Virtual IP configured in  this LoadBalancer instance
 	// +operator-sdk:csv:customresourcedefinitions:type=spec
 	// +kubebuilder:validation:Required
-	// +kubebuilder:validation:MinLength=7
+	// +kubebuilder:validation:MinLength=1
 	// +kubebuilder:validation:MaxLength=15
 	Vip string `json:"vip"`
 
@@ -127,7 +127,7 @@ type Provider struct {
 	// Vendor is the backend provider vendor
 	// +operator-sdk:csv:customresourcedefinitions:type=spec
 	// +kubebuilder:validation:Required
-	// +kubebuilder:validation:Enum=F5_BigIP;Citrix_ADC;Dummy
+	// +kubebuilder:validation:Enum=Dummy;F5_BigIP;Citrix_ADC;HAProxy
 	Vendor string `json:"vendor"`
 
 	// Host is the Load Balancer API IP or Hostname in URL format. Eg. `http://10.25.10.10`.

Diff for: bundle/manifests/lb.lbconfig.carlosedp.com_externalloadbalancers.yaml

@@ -160,9 +160,10 @@ spec:
                   vendor:
                     description: Vendor is the backend provider vendor
                     enum:
+                    - Dummy
                     - F5_BigIP
                     - Citrix_ADC
-                    - Dummy
+                    - HAProxy
                     type: string
                 required:
                 - creds
@@ -181,7 +182,7 @@ spec:
                 description: Vip is the Virtual IP configured in  this LoadBalancer
                   instance
                 maxLength: 15
-                minLength: 7
+                minLength: 1
                 type: string
             required:
             - monitor
@@ -349,9 +350,10 @@ spec:
                   vendor:
                     description: Vendor is the backend provider vendor
                     enum:
+                    - Dummy
                     - F5_BigIP
                     - Citrix_ADC
-                    - Dummy
+                    - HAProxy
                     type: string
                 required:
                 - creds

Diff for: config/crd/bases/lb.lbconfig.carlosedp.com_externalloadbalancers.yaml

@@ -161,9 +161,10 @@ spec:
                   vendor:
                     description: Vendor is the backend provider vendor
                     enum:
+                    - Dummy
                     - F5_BigIP
                     - Citrix_ADC
-                    - Dummy
+                    - HAProxy
                     type: string
                 required:
                 - creds
@@ -182,7 +183,7 @@ spec:
                 description: Vip is the Virtual IP configured in  this LoadBalancer
                   instance
                 maxLength: 15
-                minLength: 7
+                minLength: 1
                 type: string
             required:
             - monitor
@@ -350,9 +351,10 @@ spec:
                   vendor:
                     description: Vendor is the backend provider vendor
                     enum:
+                    - Dummy
                     - F5_BigIP
                     - Citrix_ADC
-                    - Dummy
+                    - HAProxy
                     type: string
                 required:
                 - creds

Diff for: config/samples/lb_v1_externalloadbalancer-haproxy-infra.yaml

@@ -0,0 +1,23 @@
+apiVersion: lb.lbconfig.carlosedp.com/v1
+kind: ExternalLoadBalancer
+metadata:
+  name: externalloadbalancer-infra-haproxy-sample
+  namespace: lbconfig-operator-system
+spec:
+  vip: "192.168.1.42"
+  nodelabels:
+    node-role.kubernetes.io/control-plane: ""
+  ports:
+    - 80
+    - 443
+  monitor:
+    path: "/healthz"
+    port: 1936
+    monitortype: http
+  provider:
+    vendor: HAProxy
+    host: "http://127.0.0.1"
+    port: 5555
+    creds: haproxy-creds
+    validatecerts: no
+    debug: true

Diff for: config/samples/lb_v1_externalloadbalancer-haproxy.yaml

@@ -0,0 +1,22 @@
+apiVersion: lb.lbconfig.carlosedp.com/v1
+kind: ExternalLoadBalancer
+metadata:
+  name: externalloadbalancer-master-haproxy-sample
+  namespace: lbconfig-operator-system
+spec:
+  vip: "*"
+  nodelabels:
+    node-role.kubernetes.io/control-plane: ""
+  ports:
+    - 6443
+  monitor:
+    path: "/healthz"
+    port: 6443
+    monitortype: "https"
+  provider:
+    vendor: HAProxy
+    host: "http://127.0.0.1"
+    port: 5555
+    creds: haproxy-creds
+    validatecerts: no
+    debug: true

Diff for: controllers/backend/backend_loader/backend_loader.go

@@ -4,5 +4,6 @@ import (
 	// Load backend modules to register them in the manager
 	_ "github.com/carlosedp/lbconfig-operator/controllers/backend/dummy"
 	_ "github.com/carlosedp/lbconfig-operator/controllers/backend/f5"
+	_ "github.com/carlosedp/lbconfig-operator/controllers/backend/haproxy"
 	_ "github.com/carlosedp/lbconfig-operator/controllers/backend/netscaler"
 )