Do use super::*; instead of use crate::common::*; (#1239)

Author: casey

src/alias.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 /// An alias, e.g. `name := target`
 #[derive(Debug, PartialEq, Clone, Serialize)]

src/analyzer.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 use CompileErrorKind::*;
 

src/assignment.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 /// An assignment, e.g `foo := bar`
 pub(crate) type Assignment<'src> = Binding<'src, Expression<'src>>;

src/assignment_resolver.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 use CompileErrorKind::*;
 

src/ast.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 /// The top-level type produced by the parser. Not all successful parses result
 /// in valid justfiles, so additional consistency checks and name resolution

src/binding.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 /// A binding of `name` to `value`
 #[derive(Debug, Clone, PartialEq, Serialize)]

src/color.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 use ansi_term::{ANSIGenericString, Color::*, Prefix, Style, Suffix};
 use atty::Stream;

src/color_display.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 pub(crate) trait ColorDisplay {
   fn color_display<'a>(&'a self, color: Color) -> Wrapper<'a>

src/command_ext.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 pub(crate) trait CommandExt {
   fn export(&mut self, settings: &Settings, dotenv: &BTreeMap<String, String>, scope: &Scope);

src/common.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 #[derive(Debug, PartialEq)]
 pub(crate) struct CompileError<'src> {

src/compile_error.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 #[derive(Debug, PartialEq)]
 pub(crate) enum CompileErrorKind<'src> {

src/compile_error_kind.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 pub(crate) struct Compiler;
 

src/compiler.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 /// A conditional expression operator.
 #[derive(PartialEq, Debug, Copy, Clone)]

src/conditional_operator.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 use clap::{App, AppSettings, Arg, ArgGroup, ArgMatches, ArgSettings};
 

src/config.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 #[derive(Debug, Snafu)]
 #[snafu(visibility(pub(crate)), context(suffix(Context)))]

src/config_error.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 pub struct Count<T: Display>(pub T, pub usize);
 

src/count.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 #[derive(PartialEq, Debug, Serialize)]
 pub(crate) struct Dependency<'src> {

src/dependency.rs

@@ -1,7 +1,7 @@
 // `Self` cannot be used where type takes generic arguments
 #![allow(clippy::use_self)]
 
-use crate::common::*;
+use super::*;
 
 pub struct Enclosure<T: Display> {
   enclosure: &'static str,

src/enclosure.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 #[derive(Debug)]
 pub(crate) enum Error<'src> {

src/error.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 pub(crate) struct Evaluator<'src: 'run, 'run> {
   assignments: Option<&'run Table<'src, Assignment<'src>>>,

src/evaluator.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 /// An expression. Note that the Just language grammar has both an `expression`
 /// production of additions (`a + b`) and values, and a `value` production of

src/expression.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 /// A line fragment consisting either of…
 #[derive(PartialEq, Debug, Clone)]

src/fragment.rs

@@ -1,7 +1,7 @@
 #![allow(unknown_lints)]
 #![allow(clippy::unnecessary_wraps)]
 
-use crate::common::*;
+use super::*;
 
 use Function::*;
 pub(crate) enum Function {

src/function.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 pub(crate) struct FunctionContext<'run> {
   pub(crate) dotenv: &'run BTreeMap<String, String>,

src/function_context.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 pub(crate) fn compile(text: &str) {
   if let Err(error) = Parser::parse(text) {

src/fuzzing.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 pub(crate) struct InterruptGuard;
 

src/interrupt_guard.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 pub(crate) struct InterruptHandler {
   blocks: u32,

src/interrupt_handler.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 /// A single top-level item
 #[derive(Debug, Clone)]

src/item.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 use serde::Serialize;
 

src/justfile.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 pub(crate) trait Keyed<'key> {
   fn key(&self) -> &'key str;

src/keyed.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 #[derive(Debug, Eq, PartialEq, IntoStaticStr, Display, Copy, Clone, EnumString)]
 #[strum(serialize_all = "kebab_case")]

src/keyword.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 use CompileErrorKind::*;
 use TokenKind::*;

src/lexer.rs

@@ -14,12 +14,81 @@
   clippy::wildcard_imports
 )]
 
+pub(crate) use {
+  crate::{
+    alias::Alias, analyzer::Analyzer, assignment::Assignment,
+    assignment_resolver::AssignmentResolver, ast::Ast, binding::Binding, color::Color,
+    color_display::ColorDisplay, command_ext::CommandExt, compile_error::CompileError,
+    compile_error_kind::CompileErrorKind, conditional_operator::ConditionalOperator,
+    config::Config, config_error::ConfigError, count::Count, delimiter::Delimiter,
+    dependency::Dependency, dump_format::DumpFormat, enclosure::Enclosure, error::Error,
+    evaluator::Evaluator, expression::Expression, fragment::Fragment, function::Function,
+    function_context::FunctionContext, interrupt_guard::InterruptGuard,
+    interrupt_handler::InterruptHandler, item::Item, justfile::Justfile, keyed::Keyed,
+    keyword::Keyword, lexer::Lexer, line::Line, list::List, load_dotenv::load_dotenv,
+    loader::Loader, name::Name, ordinal::Ordinal, output::output, output_error::OutputError,
+    parameter::Parameter, parameter_kind::ParameterKind, parser::Parser, platform::Platform,
+    platform_interface::PlatformInterface, position::Position, positional::Positional,
+    range_ext::RangeExt, recipe::Recipe, recipe_context::RecipeContext,
+    recipe_resolver::RecipeResolver, scope::Scope, search::Search, search_config::SearchConfig,
+    search_error::SearchError, set::Set, setting::Setting, settings::Settings, shebang::Shebang,
+    shell::Shell, show_whitespace::ShowWhitespace, string_kind::StringKind,
+    string_literal::StringLiteral, subcommand::Subcommand, suggestion::Suggestion, table::Table,
+    thunk::Thunk, token::Token, token_kind::TokenKind, unresolved_dependency::UnresolvedDependency,
+    unresolved_recipe::UnresolvedRecipe, use_color::UseColor, variables::Variables,
+    verbosity::Verbosity, warning::Warning,
+  },
+  std::{
+    cmp,
+    collections::{BTreeMap, BTreeSet},
+    env,
+    ffi::{OsStr, OsString},
+    fmt::{self, Debug, Display, Formatter},
+    fs,
+    io::{self, Cursor, Write},
+    iter::{self, FromIterator},
+    mem,
+    ops::{Index, Range, RangeInclusive},
+    path::{self, Path, PathBuf},
+    process::{self, Command, ExitStatus, Stdio},
+    rc::Rc,
+    str::{self, Chars},
+    sync::{Mutex, MutexGuard},
+    usize, vec,
+  },
+  {
+    camino::Utf8Path,
+    derivative::Derivative,
+    edit_distance::edit_distance,
+    lexiclean::Lexiclean,
+    libc::EXIT_FAILURE,
+    log::{info, warn},
+    regex::Regex,
+    serde::{
+      ser::{SerializeMap, SerializeSeq},
+      Serialize, Serializer,
+    },
+    snafu::{ResultExt, Snafu},
+    strum::{Display, EnumString, IntoStaticStr},
+    typed_arena::Arena,
+    unicode_width::{UnicodeWidthChar, UnicodeWidthStr},
+  },
+};
+
+#[cfg(test)]
+pub(crate) use crate::{node::Node, tree::Tree};
+
 pub use crate::run::run;
 
 // Used in integration tests.
 #[doc(hidden)]
 pub use unindent::unindent;
 
+pub(crate) type CompileResult<'a, T> = Result<T, CompileError<'a>>;
+pub(crate) type ConfigResult<T> = Result<T, ConfigError>;
+pub(crate) type RunResult<'a, T> = Result<T, Error<'a>>;
+pub(crate) type SearchResult<T> = Result<T, SearchError>;
+
 #[macro_use]
 extern crate lazy_static;
 
@@ -52,7 +121,6 @@ mod binding;
 mod color;
 mod color_display;
 mod command_ext;
-mod common;
 mod compile_error;
 mod compile_error_kind;
 mod compiler;

src/lib.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 /// A single line in a recipe body, consisting of any number of `Fragment`s.
 #[derive(Debug, Clone, PartialEq, Serialize)]

src/line.rs

@@ -1,7 +1,7 @@
 // `Self` cannot be used where type takes generic arguments
 #![allow(clippy::use_self)]
 
-use crate::common::*;
+use super::*;
 
 pub struct List<T: Display, I: Iterator<Item = T> + Clone> {
   conjunction: &'static str,

src/list.rs

@@ -1,4 +1,4 @@
-use crate::common::*;
+use super::*;
 
 const DEFAULT_DOTENV_FILENAME: &str = ".env";