Skip to content

Commit 5d88370

Browse files
author
Ryan Causey
authored
fix: remove explicit aws_s3_bucket_acl (#815)
This resolves an issue related to the April 2023 S3 API changes. More info can be found here: hashicorp/terraform-provider-aws#28353 Closes #814 ## Description Remove the explicit private ACL that leads to an error during the apply phase as with the new security defaults, it should no longer be needed. I'm not 100% on the implications of removing this resource for existing deployments, so if that's a concern we can go the route of adding the explicit `aws_s3_bucket_ownership_controls` resource as per the related issue. ## Migrations required NO ## Verification - Solves the issue in #814 using the recommendations from: hashicorp/terraform-provider-aws#28353 - manually tested and checked that the cache is still accessible
1 parent bfb53bf commit 5d88370

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

Diff for: modules/cache/main.tf

-6
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,6 @@ resource "aws_s3_bucket" "build_cache" {
3838
force_destroy = true
3939
}
4040

41-
resource "aws_s3_bucket_acl" "build_cache_acl" {
42-
bucket = aws_s3_bucket.build_cache.id
43-
44-
acl = "private"
45-
}
46-
4741
resource "aws_s3_bucket_versioning" "build_cache_versioning" {
4842
bucket = aws_s3_bucket.build_cache.id
4943

0 commit comments

Comments
 (0)