Skip to content

Commit ccaf55d

Browse files
authored
fix: always add the cache policy (#528)
* Always add the cache policy * fixed a typo in the cache docs
1 parent 5b7bf4c commit ccaf55d

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

Diff for: README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ A few option are provided to access the runner instance:
166166

167167
### GitLab runner cache
168168

169-
By default the module creates a a cache for the runner in S3. Old objects are automatically removed via a configurable life cycle policy on the bucket.
169+
By default the module creates a cache for the runner in S3. Old objects are automatically removed via a configurable life cycle policy on the bucket.
170170

171171
Creation of the bucket can be disabled and managed outside this module. A good use case is for sharing the cache across multiple runners. For this purpose the cache is implemented as a sub module. For more details see the [cache module](https://github.com/npalm/terraform-aws-gitlab-runner/tree/develop/cache). An example implementation of this use case can be found in the [runner-public](https://github.com/npalm/terraform-aws-gitlab-runner/tree/__GIT_REF__/examples/runner-public) example.
172172

Diff for: main.tf

-1
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,6 @@ resource "aws_iam_role_policy_attachment" "user_defined_policies" {
399399
### Policy for the docker machine instance to access cache
400400
################################################################################
401401
resource "aws_iam_role_policy_attachment" "docker_machine_cache_instance" {
402-
count = var.cache_bucket["create"] || lookup(var.cache_bucket, "policy", "") != "" ? 1 : 0
403402
role = aws_iam_role.instance.name
404403
policy_arn = local.bucket_policy
405404
}

0 commit comments

Comments
 (0)