Skip to content

Commit eb44182

Browse files
npalmkayman-mk
authored andcommitted
fix: add missing defaults (#905)
While checking the PR, I was not able to switch from main to the refactory-varialbes branch for the example-default. - fix a missing default - add a null check in stated of a string check
1 parent f236b58 commit eb44182

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Diff for: locals.tf

+1-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ locals {
6969
secure_parameter_store_runner_sentry_dsn = "${var.environment}-${var.runner_sentry_secure_parameter_store_name}"
7070

7171
# Custom names for runner agent instance, security groups, and IAM objects
72-
name_runner_agent_instance = var.runner_instance.name_prefix == "" ? local.tags["Name"] : var.runner_instance.name_prefix
72+
name_runner_agent_instance = var.runner_instance.name_prefix == null ? local.tags["Name"] : var.runner_instance.name_prefix
7373
name_sg = var.security_group_prefix == "" ? local.tags["Name"] : var.security_group_prefix
7474
name_iam_objects = var.iam_object_prefix == "" ? local.tags["Name"] : var.iam_object_prefix
7575

Diff for: variables.tf

+2-2
Original file line numberDiff line numberDiff line change
@@ -325,8 +325,8 @@ variable "runner_gitlab" {
325325
certificate = optional(string, "")
326326
registration_token = optional(string, "__REPLACED_BY_USER_DATA__")
327327
runner_version = optional(string, "15.8.2")
328-
url = optional(string)
329-
url_clone = optional(string)
328+
url = optional(string, "")
329+
url_clone = optional(string, "")
330330
})
331331
}
332332

0 commit comments

Comments
 (0)