fix: add kms:Encrypt permission, as needed since f25a86b5 #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @jonmcewen! 👋 Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process. Make sure that this PR clearly explains:
With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE. The following ChatOps commands are supported:
Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command. This message was generated automatically. You are welcome to improve it. |
jonmcewen
changed the title
|
Thanks for your contribution, @jonmcewen |
kayman-mk
pushed a commit
that referenced
this pull request
Oct 16, 2023
🤖 I have created a release *beep* *boop* --- ## [7.1.1](7.1.0...7.1.1) (2023-10-13) ### Bug Fixes * add kms:Encrypt permission, as needed since f25a86b ([#1008](#1008)) ([2bea7bd](2bea7bd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: Niek Palm <[email protected]> Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the addition of KeyId to the SSM parameter used to store the registration token, the replacement of the parameter following a failed token verification fails. This is due to a missing Encrypt permission on the customer managed KMS key.
The initial put-parameter presumably passes due to a shortcut on the encryption when the value is null, but the subsequent overwrite attempt fails.
Migrations required
NO
Verification
Manual addition of the kms:Encrypt permission has been proved to resolve the runner start-up failure