Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing GetParameter policy #1058

Merged

Conversation

davidramosweb
Copy link
Contributor

@davidramosweb davidramosweb commented Dec 18, 2023

Description

This pull request addresses a bug where utilizing the module with 'access_token_secure_parameter_store_name' instead of 'registration_token' results in a failure to retrieve the parameter value, leading to an error. The issue manifests when the module is applied, and subsequent attempts by the EC2 instance to fetch the parameter during runtime result in a 'permission denied' error, as observed in CloudWatch logs

Closes #1057

Migrations required

No

Copy link
Contributor

Hey @davidramosweb! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

Copy link
Collaborator

@kayman-mk kayman-mk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your fix, @davidramosweb

@kayman-mk kayman-mk merged commit e1071fa into cattle-ops:main Dec 21, 2023
kayman-mk pushed a commit that referenced this pull request Dec 21, 2023
🤖 I have created a release *beep* *boop*
---


##
[7.2.3](7.2.2...v7.2.3)
(2023-12-21)


### Bug Fixes

* add missing GetParameter policy
([#1058](#1058))
([e1071fa](e1071fa))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing the addition of the GetParameter policy to be able to retrieve a parameter from SSM
2 participants