Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support setting throughput and iops for ebs volumes #1063

Merged
merged 2 commits into from
Jan 19, 2024
Merged

feat: support setting throughput and iops for ebs volumes #1063

merged 2 commits into from
Jan 19, 2024

Conversation

tibuntu
Copy link
Contributor

@tibuntu tibuntu commented Jan 6, 2024

Description

These changes will add support for setting throughput and iops to the EBS device that is being attached to the docker_machine instance. Because setting iops is now possible, this will also allow the usage of io1 and io2 EBS volumes types.

Migrations required

No - If you consider my defaults for the two new variables as sane.

Verification

I have adapted the module configuration by changing the runner_worker_docker_machine_instance input variables:

  runner_worker_docker_machine_instance = {
    private_address_only = false
    types                = ["m5.large", "t3.xlarge", "m6a.large"]
    subnet_ids           = [module.vpc.public_subnets[0]]
    runners_idle_time    = 180
    root_size            = 30
    volume_type          = "io2"
    volume_iops          = 6000
  }

The volume was created successfully when testing the runner via Gitlab:

Screenshot 2024-01-06 at 12 14 09

Copy link
Contributor

github-actions bot commented Jan 6, 2024

Hey @tibuntu! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

@tibuntu tibuntu changed the title feat: support setting thorughput and iops for ebs volumes feat: support setting throughput and iops for ebs volumes Jan 6, 2024
@tibuntu tibuntu requested a review from kayman-mk January 15, 2024 10:22
@kayman-mk
Copy link
Collaborator

Thanks for your contribution, @tibuntu

@kayman-mk kayman-mk merged commit 796856a into cattle-ops:main Jan 19, 2024
@tibuntu tibuntu deleted the support-additional-ebs-volumes-and-volume-options branch January 19, 2024 17:46
kayman-mk pushed a commit that referenced this pull request Feb 5, 2024
🤖 I have created a release *beep* *boop*
---


##
[7.3.0](v7.2.3...v7.3.0)
(2024-01-29)


### Features

* support setting throughput and iops for ebs volumes
([#1063](#1063))
([796856a](796856a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants