feat: add support for configuring runner worker root device name #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @charlesbjohnson! 👋 Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process. Make sure that this PR clearly explains:
With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE. The following ChatOps commands are supported:
Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command. This message was generated automatically. You are welcome to improve it. |
|
Moved the images to a separate issue to get a cleaner commit message (as the whole PR description is used as commit message). |
kayman-mk
approved these changes
Jul 22, 2024
kayman-mk
pushed a commit
that referenced
this pull request
Jul 24, 2024
🤖 I have created a release *beep* *boop* --- ## [7.9.0](7.8.0...7.9.0) (2024-07-22) ### Features * add support for configuring runner worker root device name ([#1140](#1140)) ([a1f8266](a1f8266)) ### Bug Fixes * increase timeout for EC2 termination lambda ([#1156](#1156)) ([2bf6d3d](2bf6d3d)) * remove leading `/` from SSM parameter names in policy ARNs ([#1146](#1146)) ([beea51d](beea51d)) * use existing Runner package for Amazon Linux 2023 as default ([#1155](#1155)) ([c001183](c001183)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kayman-mk
added a commit
to mmoutama09/terraform-aws-gitlab-runner
that referenced
this pull request
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes add support for configuring the root device name for the Docker Machine instances. This is necessary when using an Amazon Linux AMI where the default device name of
/dev/sda1ends up creating a 2nd, unused, non-root volume.https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/device_naming.html#available-ec2-device-names
Closes #1154
Verification
Confirmed root device on Docker Machine instances is correctly configured in both fleet-mode and non-fleet mode when using an AL2 AMI. Checked this in AWS Console.