Skip to content

pre_install_script and post_install_script for workers #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task
dsalaza4 opened this issue Jul 19, 2024 · 6 comments
Closed
1 task

pre_install_script and post_install_script for workers #1150

dsalaza4 opened this issue Jul 19, 2024 · 6 comments
Labels
stale Issue/PR is stale and closed automatically

Comments

@dsalaza4
Copy link

Describe the solution you'd like

Currently, runners support start_script, pre_install_script and post_install_script via runner_install parameter.

But it seems like workers only support start_script via runner_worker_docker_machine_instance parameter.

This makes it impossible to run commands on workers right before or after base setup.

Suggest a solution

Additional context

@kayman-mk
Copy link
Collaborator

Good point. This might also be helpful for #1118

@kayman-mk
Copy link
Collaborator

Not sure if this is possible. The start_script is used as user data script on the EC2 instance.

@dsalaza4
Copy link
Author

What's more important in my opinion is being able to prepend/append custom code to the worker user data.

If start_script is currently used, then I would advise only supporting pre_start_script and post_start_script so users can do whatever they want before or after that baseline configuration.

@kayman-mk
Copy link
Collaborator

Any idea how to add this? I can't find any option for the Fleeting plugin (docker+autoscaler) and the same goes for docker+machine

Copy link
Contributor

github-actions bot commented Oct 4, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions bot added the stale Issue/PR is stale and closed automatically label Oct 4, 2024
@dsalaza4
Copy link
Author

dsalaza4 commented Oct 4, 2024

I did not have time to check this and ended up solving my specific necessity differently.

I think we can close this as it looks like no one actually has needed it so far! 🫶

@dsalaza4 dsalaza4 closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issue/PR is stale and closed automatically
Projects
None yet
Development

No branches or pull requests

2 participants