Skip to content

feat: make the graceful terminate Lambda timeout configurable #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

kayman-mk
Copy link
Collaborator

Description

Add var.runner_terminate_ec2_timeout_duration with a default of 90 seconds. Makes it possible to configure the timeout in case hundreds of workers are controlled by a single GitLab Runner Agent. Otherwise the Lambda function might fail and does not remove any worker in case the Agent is stopped.

Closes #1149

@kayman-mk kayman-mk requested a review from npalm as a code owner August 4, 2024 14:29
Copy link
Contributor

github-actions bot commented Aug 4, 2024

Hey @kayman-mk! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

Copy link
Contributor

github-actions bot commented Aug 4, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ COPYPASTE jscpd yes no 1.62s
✅ REPOSITORY checkov yes no 15.61s
✅ REPOSITORY dustilock yes no 0.38s
✅ REPOSITORY gitleaks yes no 1.22s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 12.6s
✅ REPOSITORY secretlint yes no 0.97s
✅ REPOSITORY syft yes no 0.34s
✅ REPOSITORY trivy-sbom yes no 1.43s
✅ REPOSITORY trufflehog yes no 4.5s
✅ SPELL cspell 6 0 2.94s
✅ TERRAFORM terraform-fmt 5 0 0 0.48s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@kayman-mk kayman-mk merged commit b821913 into main Aug 4, 2024
19 checks passed
@kayman-mk kayman-mk deleted the kayma/add-timeout-for-terminate branch August 4, 2024 14:32
kayman-mk pushed a commit that referenced this pull request Aug 4, 2024
🤖 I have created a release *beep* *boop*
---


##
[7.12.0](7.11.0...7.12.0)
(2024-08-04)


### Features

* make the graceful terminate Lambda timeout configurable
([#1164](#1164))
([b821913](b821913)),
closes
[#1149](#1149)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting timeout for terminate-agent-hook lambda
1 participant