Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: autoscaler asg subnets and add possibility to enable metrics for asg #1182

Conversation

mmoutama09
Copy link
Contributor

@mmoutama09 mmoutama09 commented Sep 2, 2024

Description

Add the possibility to have multiple subnets for runner manager instance with docker-autoscaler runner type.
Add the variable enabled_metrics for docker autoscaler autoscaling group

Migrations required

No

Verification

Tested on our side on a production runner.
To enable metrics for docker autoscaler autoscaling group you have to pass a list of metrics, here is my conf

runner_worker_docker_autoscaler_asg = {
         ...
         enabled_metrics  = ["GroupMinSize",  "GroupMaxSize", "GroupInServiceInstances", "GroupPendingInstances", 
                                         "GroupStandbyInstances", "GroupTerminatingInstances", "GroupTotalInstances"]

Copy link
Contributor

github-actions bot commented Sep 2, 2024

Hey @mmoutama09! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

@mmoutama09 mmoutama09 changed the title Fix autoscaler asg subnets and add possibility to enable metrics for asg fix: autoscaler asg subnets and add possibility to enable metrics for asg Sep 2, 2024
@kayman-mk
Copy link
Collaborator

Looks good to me. Thanks!

Could you please add a description to the PR and also describe how you tested the change?

@kayman-mk kayman-mk merged commit 3335b81 into cattle-ops:main Sep 5, 2024
20 of 21 checks passed
kayman-mk pushed a commit that referenced this pull request Sep 17, 2024
🤖 I have created a release *beep* *boop*
---


##
[7.14.0](7.13.1...7.14.0)
(2024-09-17)


### Features

* allow more than one job per instance
([#1184](#1184))
([f7f2ea2](f7f2ea2))


### Bug Fixes

* autoscaler asg subnets and add possibility to enable metrics for asg
([#1182](#1182))
([3335b81](3335b81))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants