chore!: remove declaration of unused variables for docker-autoscaler setup #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ikarlashov! 👋 Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process. Make sure that this PR clearly explains:
With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE. The following ChatOps commands are supported:
Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command. This message was generated automatically. You are welcome to improve it. |
ikarlashov
changed the title
ikarlashov
changed the title
kayman-mk
requested changes
Jan 30, 2025
Signed-off-by: Yevgen Karlashov <[email protected]>
kayman-mk
force-pushed
the
del_unused_vars_docker_autoscaler
branch
from
b03e8db to
f9d3349
Compare
kayman-mk
changed the title
VerificationRemove:
from |
|
As there is a major release ongoing, I decided to get rid of the variables. |
kayman-mk
changed the title
kayman-mk
approved these changes
Feb 9, 2025
kayman-mk
added a commit
that referenced
this pull request
Feb 13, 2025
🤖 I have created a release *beep* *boop* --- ## [9.0.0](8.1.0...9.0.0) (2025-02-09) ### ⚠ BREAKING CHANGES * remove declaration of unused variables for docker-autoscaler setup ([#1223](#1223)) * add custom egress rules to worker security groups ([#1222](#1222)) ### Features * add custom egress rules to worker security groups ([#1222](#1222)) ([a197e4f](a197e4f)) * enabled usage of private key with docker autoscaler ([#1232](#1232)) ([95c7ea6](95c7ea6)) ### Miscellaneous Chores * remove declaration of unused variables for docker-autoscaler setup ([#1223](#1223)) ([41058c8](41058c8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Matthias Kay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the declaration of some settings of
var.runner_worker_docker_autoscaler_asgthat are never used in the terraform manifests of the module.