-
-
Notifications
You must be signed in to change notification settings - Fork 337
Findings to run Windows worker runners #1233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @kayman-mk. these are all the settings I found to be necessary in order to make the module work with Windows runners 🙂 If you think that the findings are applicable to (almost) everyone, I this it'd be beneficial to include them somewhere in the docs since now, with |
Nice documentation! What about adding an example configuration for that? |
@kayman-mk to provide an example configuration won't be an issue, I have mine working so it's just a matter of stripping out the unnecessary/proprietary bits 🙂 For the documentation, I'm not too sure where to put it 🤔 I mean, should we just add a "Windows" section to the |
Seems to be a good place as the other examples are also referenced there. |
Hello @zillemarco! Thanks for above hints. Could you also provide full configuration for windows runners that is using this module? I'm curious how you achieved that |
Hi @pysiekytel, what do you mean? A full TF example of how I set up the module or an example of how I set up the Windows AMI for the runners? Or both? 🙂 |
Both 😅 just looking for inspiration on how people maintain this :) It does not have to be a full code for AMI creation, but just some hints of what are you using and later how you're making use of it here in module :) |
Sure, I have scheduled some time tomorrow to write the documentation/example I meant last month 😅 Sorry but I've been swallowed by a lot of things at work and this totally slipped through 😅 In the meantime, to create the AMI I used packed with a very basic setup, I'll see if I can share the packer script in a usable way 🙂 |
@pysiekytel sorry for the delay, I have opened #1268 to add the example for both the module configuration and a Packer script to create the Windows AMI. You can have a look at that whilst it's getting reviewed 🙂 |
I'm using this issue to jot down my findings while setting up this module to manage our Windows-based runners so that we can maybe add these to the docs.
Private Key is necessary
As mentioned in #1172 (comment), the private key is necessary in order for the manager to connect to the worker nodes.
This is already being addressed by #1232 and, once merged, it will be configured using:
Change the default user to
Administrator
To connect to the worker nodes the default user is set to
ec2-user
. In my case the AMI was set up to use theAdministrator
user (not sure about other AMIs).This can be configured using:
Enable Powershell path resolver
This is mentioned on the first example of the AWS fleeting plugin (https://docs.gitlab.com/runner/executors/docker_autoscaler.html#example-aws-autoscaling-for-1-job-per-instance):
This can be configured using:
Enable public IPs for the worker nodes
Not really sure why, but without a public IP the jobs would always fail with this error:
To fix this I enabled public IPs with this configuration:
Change the cache path (if cache is enabled)
By default, the cache is set up to point to the
/cache
path, which is not valid on Windows. Changing it toC:/cache
fixed it and it can be configured with these settings:Note: I tried setting it to
C:\cache
(more Windows-like) but it failed anyway. Windows likes slashes both ways, so it's not a huge deal.Disable privileged mode
By default, privileged mode is enabled but Windows does not support that so I had to disable it.
In order to do that, this configured can be used:
The text was updated successfully, but these errors were encountered: