Skip to content

fix: do not create security group rules for docker+machine if docker-autoscaler selected #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2025

Conversation

kayman-mk
Copy link
Collaborator

Description

The runner_worker_ingress_rules and runner_worker_egress_rules have to be attached to the correct security group. At the moment the module always attaches the rules to the docker machine security group which does not exist when docker-autoscaler is used.

@kayman-mk kayman-mk requested a review from npalm as a code owner February 16, 2025 21:10
Copy link
Contributor

Hey @kayman-mk! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

@kayman-mk
Copy link
Collaborator Author

Problem mentioned in #1222 (comment)

Copy link
Contributor

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ COPYPASTE jscpd yes no 1.44s
✅ REPOSITORY checkov yes no 17.81s
✅ REPOSITORY dustilock yes no 0.53s
✅ REPOSITORY gitleaks yes no 1.01s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 8.95s
✅ REPOSITORY secretlint yes no 0.83s
✅ REPOSITORY syft yes no 1.07s
✅ REPOSITORY trivy-sbom yes no 0.07s
✅ REPOSITORY trufflehog yes no 2.74s
✅ SPELL cspell 2 0 2.11s
✅ TERRAFORM terraform-fmt 1 0 0 0.04s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@kayman-mk kayman-mk merged commit 2a947e8 into main Feb 16, 2025
18 checks passed
@kayman-mk kayman-mk deleted the kayma/fix-in-egress branch February 16, 2025 21:14
kayman-mk pushed a commit that referenced this pull request Feb 16, 2025
🤖 I have created a release *beep* *boop*
---


##
[9.0.1](9.0.0...9.0.1)
(2025-02-16)


### Bug Fixes

* do not create security group rules for `docker+machine` if
`docker-autoscaler` selected
([#1243](#1243))
([2a947e8](2a947e8))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant