Skip to content

feat: allow instrumentation of Termination lambda #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Feb 27, 2025

Conversation

kayman-mk
Copy link
Collaborator

@kayman-mk kayman-mk commented Feb 27, 2025

Description

This PR adds the possibility to instrument the internal Lambda function, e.g. with APM tools. Use the following variables:

  • runner_terminate_ec2_lambda_handler to replace the handler with your function
  • runner_terminate_ec2_environment_variables to add environment variables. The special value {HANDLER} is automatically replaced by the internal handler name to be able to call the "real" handler
  • runner_terminate_ec2_lambda_handler_layer_arns to add additional layers to the Lambda function
  • runner_terminate_ec2_lambda_egress_rules to allow traffic to external systems. IPv4/6 port 443 is the default

x

Verified

This commit was signed with the committer’s verified signature.
elliotwutingfeng Wu Tingfeng
@kayman-mk kayman-mk requested a review from npalm as a code owner February 27, 2025 09:11
Copy link
Contributor

Hey @kayman-mk! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

Copy link
Contributor

github-actions bot commented Feb 27, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ COPYPASTE jscpd yes no 1.64s
✅ MARKDOWN markdownlint 1 0 0 0.85s
✅ MARKDOWN markdown-link-check 1 0 1.75s
✅ REPOSITORY checkov yes no 17.62s
✅ REPOSITORY dustilock yes no 0.62s
✅ REPOSITORY gitleaks yes no 0.99s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 8.19s
✅ REPOSITORY secretlint yes no 0.72s
✅ REPOSITORY syft yes no 1.08s
✅ REPOSITORY trivy-sbom yes no 0.07s
✅ REPOSITORY trufflehog yes no 2.54s
✅ SPELL cspell 9 0 2.72s
✅ TERRAFORM terraform-fmt 7 0 0 0.46s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@kayman-mk kayman-mk merged commit 55af1d1 into main Feb 27, 2025
20 checks passed
@kayman-mk kayman-mk deleted the kayma/instrument-lambda branch February 27, 2025 10:45
kayman-mk pushed a commit that referenced this pull request Feb 27, 2025
🤖 I have created a release *beep* *boop*
---


##
[9.1.0](9.0.2...9.1.0)
(2025-02-27)


### Features

* allow instrumentation of Termination lambda
([#1255](#1255))
([55af1d1](55af1d1))


### Bug Fixes

* allow terminate Lambda to access kms key
([#1253](#1253))
([48c5a37](48c5a37))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant