Skip to content

EBS Encryption has the wrong name - 'kms_key_id' should be kms_key_id #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lee-chrisbell opened this issue Dec 30, 2021 · 2 comments
Closed

Comments

@lee-chrisbell
Copy link
Contributor

There is a difference in the documentation and the actual code for using the kms_key_id to encrypt the EBS volume -

  dynamic "block_device_mappings" {
    for_each = [var.runner_root_block_device]
    content {
      device_name = lookup(block_device_mappings.value, "device_name", "/dev/xvda")
      ebs {
        delete_on_termination = lookup(block_device_mappings.value, "delete_on_termination", true)
        volume_type           = lookup(block_device_mappings.value, "volume_type", "gp3")
        volume_size           = lookup(block_device_mappings.value, "volume_size", 8)
        encrypted             = lookup(block_device_mappings.value, "encrypted", true)
        iops                  = lookup(block_device_mappings.value, "iops", null)
        kms_key_id            = lookup(block_device_mappings.value, "`kms_key_id`", null) // HERE
      }
    }
  }
@lee-chrisbell lee-chrisbell changed the title EBS Encryption has the wrong name - kms_key_id should be kms_key_id EBS Encryption has the wrong name - \kms_key_id\ should be kms_key_id Dec 30, 2021
@lee-chrisbell lee-chrisbell changed the title EBS Encryption has the wrong name - \kms_key_id\ should be kms_key_id EBS Encryption has the wrong name - 'kms_key_id' should be kms_key_id Dec 30, 2021
@kayman-mk
Copy link
Collaborator

@lee-chrisbell Could you please close this issue? Seems that you fixed it with #422, right?

@npalm npalm closed this as completed Jan 6, 2022
@lee-chrisbell
Copy link
Contributor Author

Looks like @npalm just did. Sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants