Skip to content

Multiple tmpfs volume entries doesn't work #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ntsim opened this issue May 8, 2022 · 1 comment · Fixed by #480
Closed

Multiple tmpfs volume entries doesn't work #479

ntsim opened this issue May 8, 2022 · 1 comment · Fixed by #480
Labels

Comments

@ntsim
Copy link

ntsim commented May 8, 2022

Currently on v4.14.1.

I attempted to add multiple tmpfs options with a configuration like the following:

runners_services_volumes_tmpfs = [
  {
    volume  = "/var/lib/mysql",
    options = "rw,noexec"
  },
  {
    volume  = "/var/lib/postgresql/data",
    options = "rw,noexec"
  }
]

Unfortunately, this seems to result in the gitlab-runner installation failing with the following error:

Near line 32 (last key parsed 'runners.docker.services_tmpfs'): expected a top-level item to end with a newline, comment, or EOF, but got ',' instead

The gitlab-runner service consequently can't start up and registration fails.

The issue seems to be that the runners_volumes_tmpfs and runners_services_volumes_tmpfs options attempt to concatenate everything together with commas and this produces an invalid runner config.toml:

[runners.docker.services_tmpfs]
"/var/lib/mysql/" = "rw,noexec", "/var/lib/postgresql/data" = "rw,noexec"

Versus what we should expect:

[runners.docker.services_tmpfs]
"/var/lib/mysql/" = "rw,noexec"
"/var/lib/postgresql/data" = "rw,noexec"
@semantic-releaser
Copy link
Contributor

🎉 This issue has been resolved in version 4.42.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant