- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 338
feat: support self-signed certificates #584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kayman-mk please take a look. |
Just a note, I could only get this to work with the With Perhaps if someone else in future wants this functionality they can provide a PR for it. |
fbf8a48
to
8e6244e
Compare
I will do a quick check in my environment. Code looks good. |
Verified that my runners in a complex scenario are still running (without using the new feature): Success |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the PR on the default branch, docker machines are not starting healthy. Build are not starting.
NAME ACTIVE DRIVER STATE URL SWARM DOCKER ERRORS
runner-gksonazu-npalm-1670767825-0f2da2d9 - amazonec2 Running tcp://10.0.1.93:2376 Unknown Unable to query dockerversion: Cannot connect to the docker engine endpoint
So seems the change in the start scripts breaks the runners.
Another run, now it seems working. Would like to check the PR in a bit more detail |
@npalm any chance this one can get merged in? being able to customize certs makes dind possible, among other things. |
@npalm Could you please recheck? Looks good here. Tested the "no own certificate" path only. So nobody should be affected by this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baolsen sorry for the late response. But it seems the PR is not merged correctly. I made on one place a comment, but it seems there are multiple places where the reabase went wrong. Please can you fix the rebase?
@kayman-mk I also checked the default example. For me the PR is OK. But the only thing that is strange is. When I do a local rebase with main, I got merge conflicts. But form reason they are not shown here. |
@baolsen thank you for you contribution! |
Description
This change simply allows the Gitlab runner to register and run with a self-signed gitlab instance. The runner helper image can access such an instance.
Closes #563
Migrations required
NO
Verification
I've verified that the iniital change works in my own environment where I have self-signed certificates in use.
I have not verified that the changes after enabling pre-commit and tf docs etc work, but they should...