fix: remove empty elements from tag list #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @kayman-mk! 👋 Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process. Make sure that this PR clearly explains:
With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE. The following ChatOps commands are supported:
Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command. This message was generated automatically. You are welcome to improve it. |
kayman-mk
force-pushed
the
kayma/fix-no-tags
branch
from
d1d6189 to
c71da14
Compare
kayman-mk
force-pushed
the
main
branch
2 times, most recently
from
585afba to
156fb63
Compare
kayman-mk
force-pushed
the
kayma/fix-no-tags
branch
2 times, most recently
from
c71da14 to
63706ad
Compare
kayman-mk
force-pushed
the
kayma/fix-no-tags
branch
from
63706ad to
1adc3b1
Compare
kayman-mk
pushed a commit
that referenced
this pull request
Aug 31, 2023
🤖 I have created a release *beep* *boop* --- ## [6.5.2](6.5.1...6.5.2) (2023-08-31) ### Bug Fixes * remove empty elements from tag list ([#936](#936)) ([3b4a95e](3b4a95e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: Niek Palm <[email protected]> Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In rare cases the
amazonec2-tagsmay contain empty elements which show up as,__PARENT_TAG__which is not a valid value for AWS API to create an instance.The problem is that
runner_tagsmust be removed if it is empty. Otherwise the empty element is inserted into the final string which results in a preceding,.Closes #933
Verification
Verified manually with
__PARENT_TAG__tag1,value1,__PARENT_TAG