Skip to content

Commit fb5e0eb

Browse files
committed
[canvaskit] Pass in paints via reference
I don't believe this impacts performance, but we'll see. Change-Id: I5eb0843c186b61f4d34162c6fbc25c92b49a55a9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315862 Reviewed-by: Nathaniel Nifong <[email protected]>
1 parent 3d41d50 commit fb5e0eb

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

modules/canvaskit/canvaskit_bindings.cpp

+5-5
Original file line numberDiff line numberDiff line change
@@ -655,7 +655,7 @@ class ShapedText {
655655
};
656656

657657
void drawShapedText(SkCanvas& canvas, ShapedText st, SkScalar x,
658-
SkScalar y, SkPaint paint) {
658+
SkScalar y, const SkPaint& paint) {
659659
canvas.drawTextBlob(st.blob(), x, y, paint);
660660
}
661661
#endif //SK_NO_FONTS
@@ -1024,7 +1024,7 @@ EMSCRIPTEN_BINDINGS(Skia) {
10241024
}), allow_raw_pointers())
10251025
.function("drawLine", select_overload<void (SkScalar, SkScalar, SkScalar, SkScalar, const SkPaint&)>(&SkCanvas::drawLine))
10261026
.function("_drawOval", optional_override([](SkCanvas& self, uintptr_t /* float* */ fPtr,
1027-
const SkPaint paint)->void {
1027+
const SkPaint& paint)->void {
10281028
const SkRect* oval = reinterpret_cast<const SkRect*>(fPtr);
10291029
self.drawOval(*oval, paint);
10301030
}))
@@ -1041,21 +1041,21 @@ EMSCRIPTEN_BINDINGS(Skia) {
10411041
.function("drawPicture", select_overload<void (const sk_sp<SkPicture>&)>(&SkCanvas::drawPicture))
10421042
.function("_drawPoints", optional_override([](SkCanvas& self, SkCanvas::PointMode mode,
10431043
uintptr_t /* SkPoint* */ pptr,
1044-
int count, SkPaint paint)->void {
1044+
int count, SkPaint& paint)->void {
10451045
const SkPoint* pts = reinterpret_cast<const SkPoint*>(pptr);
10461046
self.drawPoints(mode, count, pts, paint);
10471047
}))
10481048
.function("_drawRRect",optional_override([](SkCanvas& self, uintptr_t /* float* */ fPtr, const SkPaint& paint) {
10491049
self.drawRRect(ptrToSkRRect(fPtr), paint);
10501050
}))
10511051
.function("_drawRect", optional_override([](SkCanvas& self, uintptr_t /* float* */ fPtr,
1052-
const SkPaint paint)->void {
1052+
const SkPaint& paint)->void {
10531053
const SkRect* rect = reinterpret_cast<const SkRect*>(fPtr);
10541054
self.drawRect(*rect, paint);
10551055
}))
10561056
.function("drawRect4f", optional_override([](SkCanvas& self, SkScalar left, SkScalar top,
10571057
SkScalar right, SkScalar bottom,
1058-
const SkPaint paint)->void {
1058+
const SkPaint& paint)->void {
10591059
const SkRect rect = SkRect::MakeLTRB(left, top, right, bottom);
10601060
self.drawRect(rect, paint);
10611061
}))

0 commit comments

Comments
 (0)