Skip to content

Commit c75bff7

Browse files
defanatorFelipe Zimmerle
authored and
Felipe Zimmerle
committed
Tests: adjust TODO after improving configuration merging in library
See owasp-modsecurity/ModSecurity#1990 for details.
1 parent b08c56d commit c75bff7

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

Diff for: tests/modsecurity-config-merge.t

-4
Original file line numberDiff line numberDiff line change
@@ -162,9 +162,6 @@ $t->plan(10);
162162
like(http_get_body('/', 'GOOD BODY'), qr/TEST-OK-IF-YOU-SEE-THIS/, "http level defaults, pass");
163163
like(http_get_body('/', 'VERY BAD BODY'), qr/403 Forbidden/, "http level defaults, block");
164164

165-
TODO: {
166-
local $TODO = 'not yet, see https://github.com/SpiderLabs/ModSecurity/pull/1990';
167-
168165
like(http_get_body('/modsec-disabled', 'VERY BAD BODY'), qr/TEST-OK-IF-YOU-SEE-THIS/, "location override for SecRuleEngine, pass");
169166
like(http_get_body('/nobodyaccess', 'VERY BAD BODY'), qr/TEST-OK-IF-YOU-SEE-THIS/, "location override for SecRequestBodyAccess, pass");
170167
like(http_get_body('/bodylimitprocesspartial', 'BODY' x 33), qr/TEST-OK-IF-YOU-SEE-THIS/, "location override for SecRequestBodyLimitAction, pass");
@@ -174,7 +171,6 @@ like(http_get_body('/server/modsec-disabled', 'VERY BAD BODY'), qr/TEST-OK-IF-YO
174171
like(http_get_body('/server/nobodyaccess', 'VERY BAD BODY'), qr/TEST-OK-IF-YOU-SEE-THIS/, "server override for SecRequestBodyAccess, pass");
175172
like(http_get_body('/server/bodylimitprocesspartial', 'BODY' x 33), qr/TEST-OK-IF-YOU-SEE-THIS/, "server override for SecRequestBodyLimitAction, pass");
176173
like(http_get_body('/server/bodylimitincreased', 'BODY' x 64), qr/TEST-OK-IF-YOU-SEE-THIS/, "server override for SecRequestBodyLimit, pass");
177-
}
178174

179175
###############################################################################
180176

Diff for: tests/modsecurity-request-body.t

-4
Original file line numberDiff line numberDiff line change
@@ -166,13 +166,9 @@ like(
166166
'POST with auth_request (request size < client_header_buffer_size), no preread'
167167
);
168168

169-
TODO: {
170-
local $TODO = 'not yet';
171-
172169
foreach my $method (('GET', 'POST', 'PUT', 'DELETE')) {
173170
like(http_req_body($method, '/bodylimitrejectserver', 'BODY' x 33), qr/403 Forbidden/, "$method request body limit reject, block (inherited SecRequestBodyLimit)");
174171
}
175-
}
176172

177173
###############################################################################
178174

0 commit comments

Comments
 (0)