Skip to content

Commit 5131258

Browse files
authored
Remove unnecessary build step for some workflows (rust-lang#3124)
Workflows that run the perf regressions (`scripts/kani-perf.sh`) do not need to build Kani, as the perf script itself builds Kani in release mode: https://github.com/model-checking/kani/blob/dc0978043c52492112e4ad37a617fd3c8100ef1f/scripts/kani-perf.sh#L12 The extra build step was causing Kani to be built two extra times for the `benchcomp` flow because the workflow was building it in debug mode, so the script will end up rebuilding it in release mode. This should save about 3 minutes for the `benchcomp` flow.
1 parent a589e57 commit 5131258

File tree

4 files changed

+0
-19
lines changed

4 files changed

+0
-19
lines changed

.github/workflows/bench.yml

-6
Original file line numberDiff line numberDiff line change
@@ -55,12 +55,6 @@ jobs:
5555
os: ubuntu-20.04
5656
kani_dir: new
5757

58-
- name: Build Kani (new variant)
59-
run: pushd new && cargo build-dev
60-
61-
- name: Build Kani (old variant)
62-
run: pushd old && cargo build-dev
63-
6458
- name: Copy benchmarks from new to old
6559
run: rm -rf ./old/tests/perf ; cp -r ./new/tests/perf ./old/tests/
6660

.github/workflows/cbmc-latest.yml

-4
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@ jobs:
3232
os: ${{ matrix.os }}
3333
kani_dir: 'kani'
3434

35-
- name: Build Kani
36-
working-directory: ./kani
37-
run: cargo build-dev
38-
3935
- name: Checkout CBMC under "cbmc"
4036
uses: actions/checkout@v4
4137
with:

.github/workflows/kani-m1.yml

-3
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,5 @@ jobs:
2323
with:
2424
os: macos-13-xlarge
2525

26-
- name: Build Kani
27-
run: cargo build-dev
28-
2926
- name: Execute Kani regression
3027
run: ./scripts/kani-regression.sh

.github/workflows/kani.yml

-6
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,6 @@ jobs:
2727
with:
2828
os: ${{ matrix.os }}
2929

30-
- name: Build Kani
31-
run: cargo build-dev
32-
3330
- name: Execute Kani regression
3431
run: ./scripts/kani-regression.sh
3532

@@ -88,9 +85,6 @@ jobs:
8885
with:
8986
os: ubuntu-20.04
9087

91-
- name: Build Kani using release mode
92-
run: cargo build-dev -- --release
93-
9488
- name: Execute Kani performance tests
9589
run: ./scripts/kani-perf.sh
9690
env:

0 commit comments

Comments
 (0)