Skip to content

Commit 76676ab

Browse files
committed
chore(internal): fix binary response tests (openai#983)
1 parent 2735873 commit 76676ab

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

tests/api_resources/audio/test_speech.py

+2-4
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,7 @@ def test_method_create(self, client: OpenAI, respx_mock: MockRouter) -> None:
3939
@pytest.mark.respx(base_url=base_url)
4040
def test_method_create_with_all_params(self, client: OpenAI, respx_mock: MockRouter) -> None:
4141
respx_mock.post("/audio/speech").mock(return_value=httpx.Response(200, json={"foo": "bar"}))
42-
speech = respx_mock.post("/audio/speech").mock(return_value=httpx.Response(200, json={"foo": "bar"}))
43-
client.audio.speech.create(
42+
speech = client.audio.speech.create(
4443
input="string",
4544
model="string",
4645
voice="alloy",
@@ -89,8 +88,7 @@ async def test_method_create(self, client: AsyncOpenAI, respx_mock: MockRouter)
8988
@pytest.mark.respx(base_url=base_url)
9089
async def test_method_create_with_all_params(self, client: AsyncOpenAI, respx_mock: MockRouter) -> None:
9190
respx_mock.post("/audio/speech").mock(return_value=httpx.Response(200, json={"foo": "bar"}))
92-
speech = respx_mock.post("/audio/speech").mock(return_value=httpx.Response(200, json={"foo": "bar"}))
93-
await client.audio.speech.create(
91+
speech = await client.audio.speech.create(
9492
input="string",
9593
model="string",
9694
voice="alloy",

tests/api_resources/test_files.py

+4-8
Original file line numberDiff line numberDiff line change
@@ -95,22 +95,20 @@ def test_raw_response_delete(self, client: OpenAI) -> None:
9595
file = response.parse()
9696
assert_matches_type(FileDeleted, file, path=["response"])
9797

98-
@pytest.mark.skip(reason="mocked response isn't working yet")
9998
@parametrize
10099
@pytest.mark.respx(base_url=base_url)
101100
def test_method_content(self, client: OpenAI, respx_mock: MockRouter) -> None:
102-
respx_mock.get("/files/{file_id}/content").mock(return_value=httpx.Response(200, json={"foo": "bar"}))
101+
respx_mock.get("/files/string/content").mock(return_value=httpx.Response(200, json={"foo": "bar"}))
103102
file = client.files.content(
104103
"string",
105104
)
106105
assert isinstance(file, BinaryResponseContent)
107106
assert file.json() == {"foo": "bar"}
108107

109-
@pytest.mark.skip(reason="mocked response isn't working yet")
110108
@parametrize
111109
@pytest.mark.respx(base_url=base_url)
112110
def test_raw_response_content(self, client: OpenAI, respx_mock: MockRouter) -> None:
113-
respx_mock.get("/files/{file_id}/content").mock(return_value=httpx.Response(200, json={"foo": "bar"}))
111+
respx_mock.get("/files/string/content").mock(return_value=httpx.Response(200, json={"foo": "bar"}))
114112
response = client.files.with_raw_response.content(
115113
"string",
116114
)
@@ -212,22 +210,20 @@ async def test_raw_response_delete(self, client: AsyncOpenAI) -> None:
212210
file = response.parse()
213211
assert_matches_type(FileDeleted, file, path=["response"])
214212

215-
@pytest.mark.skip(reason="mocked response isn't working yet")
216213
@parametrize
217214
@pytest.mark.respx(base_url=base_url)
218215
async def test_method_content(self, client: AsyncOpenAI, respx_mock: MockRouter) -> None:
219-
respx_mock.get("/files/{file_id}/content").mock(return_value=httpx.Response(200, json={"foo": "bar"}))
216+
respx_mock.get("/files/string/content").mock(return_value=httpx.Response(200, json={"foo": "bar"}))
220217
file = await client.files.content(
221218
"string",
222219
)
223220
assert isinstance(file, BinaryResponseContent)
224221
assert file.json() == {"foo": "bar"}
225222

226-
@pytest.mark.skip(reason="mocked response isn't working yet")
227223
@parametrize
228224
@pytest.mark.respx(base_url=base_url)
229225
async def test_raw_response_content(self, client: AsyncOpenAI, respx_mock: MockRouter) -> None:
230-
respx_mock.get("/files/{file_id}/content").mock(return_value=httpx.Response(200, json={"foo": "bar"}))
226+
respx_mock.get("/files/string/content").mock(return_value=httpx.Response(200, json={"foo": "bar"}))
231227
response = await client.files.with_raw_response.content(
232228
"string",
233229
)

0 commit comments

Comments
 (0)