Skip to content

Commit 9b3fc36

Browse files
committed
Use service builder for DriverFinder
1 parent bf24f19 commit 9b3fc36

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

Diff for: examples/ruby/spec/browsers/chrome_spec.rb

+2-1
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,8 @@
115115

116116
def driver_finder
117117
options = Selenium::WebDriver::Options.chrome(browser_version: 'stable')
118-
finder = Selenium::WebDriver::DriverFinder.new(options, Selenium::WebDriver::Chrome::Service.new)
118+
service = Selenium::WebDriver::Service.chrome
119+
finder = Selenium::WebDriver::DriverFinder.new(options, service)
119120
ENV['CHROMEDRIVER_BIN'] = finder.driver_path
120121
ENV['CHROME_BIN'] = finder.browser_path
121122
end

Diff for: examples/ruby/spec/browsers/edge_spec.rb

+2-1
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,8 @@
115115

116116
def driver_finder
117117
options = Selenium::WebDriver::Options.edge(browser_version: 'stable')
118-
finder = Selenium::WebDriver::DriverFinder.new(options, Selenium::WebDriver::Edge::Service.new)
118+
service = Selenium::WebDriver::Service.edge
119+
finder = Selenium::WebDriver::DriverFinder.new(options, service)
119120
ENV['EDGEDRIVER_BIN'] = finder.driver_path
120121
ENV['EDGE_BIN'] = finder.browser_path
121122
end

Diff for: examples/ruby/spec/browsers/firefox_spec.rb

+2-1
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,8 @@
122122

123123
def driver_finder
124124
options = Selenium::WebDriver::Options.firefox(browser_version: 'stable')
125-
finder = Selenium::WebDriver::DriverFinder.new(options, Selenium::WebDriver::Firefox::Service.new)
125+
service = Selenium::WebDriver::Service.firefox
126+
finder = Selenium::WebDriver::DriverFinder.new(options, service)
126127
ENV['GECKODRIVER_BIN'] = finder.driver_path
127128
ENV['FIREFOX_BIN'] = finder.browser_path
128129
end

Diff for: examples/ruby/spec/drivers/service_spec.rb

+2-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@
3333

3434
def driver_finder
3535
options = Selenium::WebDriver::Options.chrome(browser_version: 'stable')
36-
finder = Selenium::WebDriver::DriverFinder.new(options, Selenium::WebDriver::Chrome::Service.new)
36+
service = Selenium::WebDriver::Service.chrome
37+
finder = Selenium::WebDriver::DriverFinder.new(options, service)
3738
ENV['CHROMEDRIVER_BIN'] = finder.driver_path
3839
ENV['CHROME_BIN'] = finder.browser_path
3940
end

0 commit comments

Comments
 (0)