Skip to content

Commit 5a0f86d

Browse files
fixup! use unique_ptr instead of PointerStorage
1 parent 87a5b83 commit 5a0f86d

File tree

3 files changed

+12
-8
lines changed

3 files changed

+12
-8
lines changed

lib/Demangling/Context.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,10 @@ NodePointer Context::demangleTypeAsNode(llvm::StringRef MangledName) {
5555

5656
#if SWIFT_STDLIB_HAS_TYPE_PRINTING
5757

58-
std::string Context::demangleSymbolAsString(llvm::StringRef MangledName,
59-
const DemangleOptions &Options,
60-
std::unique_ptr<DemanglerPrinter> printer) {
58+
std::string
59+
Context::demangleSymbolAsString(llvm::StringRef MangledName,
60+
const DemangleOptions &Options,
61+
std::unique_ptr<DemanglerPrinter> printer) {
6162
NodePointer root = demangleSymbolAsNode(MangledName);
6263
if (!root) return MangledName.str();
6364

lib/Demangling/NodePrinter.cpp

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -168,8 +168,8 @@ static StringRef toString(ValueWitnessKind k) {
168168
}
169169

170170
template <typename T>
171-
auto operator<<(const std::unique_ptr<DemanglerPrinter> &printer,
172-
const T &n) -> decltype((*printer) << n) {
171+
auto operator<<(const std::unique_ptr<DemanglerPrinter> &printer, const T &n)
172+
-> decltype((*printer) << n) {
173173
return (*printer) << n;
174174
}
175175

@@ -181,8 +181,10 @@ class NodePrinter {
181181
bool isValid = true;
182182

183183
public:
184-
NodePrinter(DemangleOptions options, std::unique_ptr<DemanglerPrinter> printer = nullptr)
185-
: Printer(printer ? std::move(printer) : std::make_unique<DemanglerPrinter>()),
184+
NodePrinter(DemangleOptions options,
185+
std::unique_ptr<DemanglerPrinter> printer = nullptr)
186+
: Printer(printer ? std::move(printer)
187+
: std::make_unique<DemanglerPrinter>()),
186188
Options(options) {}
187189

188190
std::string printRoot(NodePointer root) {

tools/swift-demangle/swift-demangle.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,8 @@ static void demangle(llvm::raw_ostream &os, llvm::StringRef name,
290290
os << printer->getNameStart() << "," << printer->getNameEnd();
291291
os << ") - (";
292292
if (printer->hasParameters())
293-
os << printer->getParametersStart() << "," << printer->getParametersEnd();
293+
os << printer->getParametersStart() << ","
294+
<< printer->getParametersEnd();
294295
os << ")}";
295296
}
296297
}

0 commit comments

Comments
 (0)