Skip to content

Flowcharts do not render #10615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 3 tasks
LeeLenaleee opened this issue Aug 22, 2022 · 3 comments · Fixed by #10621
Closed
1 of 3 tasks

Flowcharts do not render #10615

LeeLenaleee opened this issue Aug 22, 2022 · 3 comments · Fixed by #10621

Comments

@LeeLenaleee
Copy link
Collaborator

Documentation Is:

  • Missing or needed?
  • Confusing
  • Not sure?

Please Explain in Detail...

The flowcharts in on the plugin page that show the rendering sequence don't render anymore.

@benmccann not totally sure but I think its since the switch to pnpm (same for the fix of #10593) do you have any idea what might be the cause of this?

Your Proposal for Changes

Fix that the render loop is shown again before going to a stable release of V4

Example

https://www.chartjs.org/docs/master/developers/plugins.html

@benmccann
Copy link
Contributor

Seems like we ended up with some incompatible library versions when changing the lockfile from the npm lockfile to pnpm lockfile. It looks like this issue: vuejs/vue-loader#1612

If there isn't a need to deploy a working version in the short-term, I'd rather fix this by switching to Vitepress (#10583)

@etimberg etimberg added this to the Version 4.0 milestone Aug 22, 2022
@LeeLenaleee
Copy link
Collaborator Author

Im fine with that as long as there is no clear release date in sight since vitepress is still in alfa I dont know how much will change and if we make the version plugin again for vitepress for example we might need to do it again when it goes to stable.

So for now waiting is fine since its only master thats affected, otherwise we need to look into fixing this

@dangreen
Copy link
Collaborator

@benmccann @LeeLenaleee Hi. I know how to fix this. I will make PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants